Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with PHP 8.0 #675

Open
wants to merge 1 commit into
base: 6.x
Choose a base branch
from
Open

Make compatible with PHP 8.0 #675

wants to merge 1 commit into from

Conversation

s-damian
Copy link
Contributor

@s-damian s-damian commented Dec 5, 2020

Please, Is it possible to update the SVP package?
Thank you

@repat
Copy link
Contributor

repat commented Dec 8, 2020

#671

@dmitryuk
Copy link

@Stephweb please close pull request

@nickfls
Copy link

nickfls commented Dec 16, 2021

@dev-and-web there's more in #696

and also, I was wondering, maybe replace the whole if block (in FormBuilder and FormAccessible) with?

return optional($this->model)->getFormValue($key);

equal use in:
/Eloquent/FormAccessible.php:52
/FormBuilder.php:1365

@nickfls
Copy link

nickfls commented Dec 16, 2021

Never mind; I see the code already moved on and this PR could be closed.
#696 however is not addressed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants