-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add square wasi without gitignore #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going to merge this now as it is a big step forward.
I think there is more to do here for DevX.
One small comment (for you) is that if we commit bindings.rs
and it causes cargo fmt
issues, this is a bit annoying. When does it get rebuilt?
Is it possible to add a rustfmt.toml
file such that bindings.rs
would be correctly formatted? (I am not too particular on formating styles.. just odd that auto-gen fails on cargo fmt and nice if this "just works")
cargo binstall cargo-component | ||
``` | ||
|
||
The configuration for registry mappings is in the process of getting better, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for these docs, I never would have figured it out on my own.
| macOS | `/Users/<username>/Library/Application Support` | | ||
| Windows | `C:\Users\<username>\AppData\Roaming` | | ||
|
||
The configuration file is TOML and currently must be edited manually. A future release will include |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to use wkg somehow? Or does this happen automatically?
Can you document the process to updating the wit files (which I assume is what wkg is doing)? Or explain how it relates to the toolchain
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cargo-component
shares the wkg
config. Installing wkg
is optional for this workflow. This is all very new. Days old and actively being improved.
Yep, I will document. Put in Wasmatic repo?
It gets rebuilt with the
Created an issue in cargo component. |
💯 Agree that the DX needs a lot more work. But fixable and can improve incrementally every day. Expect to be in a better place before the end of this week. |
This is a branch off of #23 that can replace that PR.
Closes #16
The instructions to configure your local setup and build the component will get simpler before the hackathon. You shouldn't need to manually edit a file, it will be a CLI command or something configurable in a local toml file (Cargo.toml or another file).