Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add rewards-v2 related functionality #221

Merged
merged 9 commits into from
Jan 16, 2025
Merged

feat: add rewards-v2 related functionality #221

merged 9 commits into from
Jan 16, 2025

Conversation

supernovahs
Copy link
Collaborator

@supernovahs supernovahs commented Jan 16, 2025

Updated rewards v2 bindings tracking https://github.com/Layr-Labs/eigenlayer-middleware/tree/dev
TODO

  • Update readme with commands to generate bindings

  • Add functions

set_operator_avs_split
set_operator_pi_split
get_operator_avs_split
get_operator_pi_split

Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Did you generate the bindings with the commands from dev's Makefile?

@supernovahs
Copy link
Collaborator Author

supernovahs commented Jan 16, 2025

LGTM. Did you generate the bindings with the commands from dev's Makefile?

used your closed PR for bindings as reference for these commands
But you have to manually cd and run forge build here
thinking how to add it and the above commands in readme or do it in a makefile ?
https://github.com/Layr-Labs/eigensdk-rs/blob/rewards_v2/crates/utils/src/lib.rs

@MegaRedHand
Copy link
Contributor

I merged it in dev branch https://github.com/Layr-Labs/eigensdk-rs/blob/dev/Makefile#L63. I could cherry-pick that commit back to main I guess. Give me a moment

@MegaRedHand
Copy link
Contributor

MegaRedHand commented Jan 16, 2025

Done: d02b8dc

@MegaRedHand
Copy link
Contributor

@supernovahs We fixed the broken test in 7895be8

Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supernovahs supernovahs marked this pull request as ready for review January 16, 2025 19:56
@supernovahs
Copy link
Collaborator Author

need to update anvil state to pass the tests, will wait for #222

supernovahs added 2 commits January 17, 2025 02:45
…or_avs_split,get_operator_pi_split,get_operator_avs_split
@supernovahs
Copy link
Collaborator Author

lol 🤣 , looks like it passed, the state already included rewards v2 i guess

Copy link
Contributor

@MegaRedHand MegaRedHand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@supernovahs supernovahs merged commit 93c21cc into main Jan 16, 2025
3 checks passed
@MegaRedHand MegaRedHand deleted the rewards_v2 branch January 17, 2025 15:47
@MegaRedHand MegaRedHand changed the title rewardsv2 feat: add Rewards-v2 related functionality Jan 17, 2025
@MegaRedHand MegaRedHand changed the title feat: add Rewards-v2 related functionality feat: add rewards-v2 related functionality Jan 17, 2025
@MegaRedHand MegaRedHand added the changelog-added [changelog] PR adds a new feature label Jan 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-added [changelog] PR adds a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants