-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CSS 2 #222
Added CSS 2 #222
Conversation
I have not reviewed all the changes yet, but two things already come to my mind:
|
36f3b7f
to
301aa53
Compare
@PolariTOON Thank you for the review! I've now split up the specification into smaller ones covering the different parts as you suggested. Could you please make another review? Sebastian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I spotted some nits and maybe basic selectors and media queries could be tested, but overall this looks good.
@PolariTOON Thank you for the detailed review! I've addressed everything you've mentioned. Could you please review it again? Sebastian |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It's interesting to see that some features that were introduced right back in CSS2 are still not fully supported nowadays in major browsers: orphans
, widows
, outline-color: invert
...
Thank you again for the reviews!
Yes, interestingly, according to MDN web docs it seems that And I just realized again why I didn't include the keyword initially. The spec. says this:
So, as I merged the PR already, I guess I should create a new PR to remove the test for it again. Sebastian |
And btw., the implementation of @LeaVerou There we have something that's unimplemented for 20 years. And I am sure they will be implemented at some point because Firefox is the only browser that doesn't support those properties and there is still author interest for them. Sebastian |
I just removed it again in 93faed6. Sebastian |
This change adds everything introduced in CSS 2 Revision 1. It also moves tests of things into CSS 2 that were initially introduced there but were tested in other specs so far.
The tests include the deprecated
clip
property because browsers are still required to support it.I skipped all aural properties like
speak
,cue
,volume
, etc. because they are non-normative and removed in the newest working draft of the spec.Note that this should wait until #212 is merged, so we have a way to filter CSS 2 out. Though you can already review all the changes made. In the end I'll just add a filter that includes every spec. including CSS 2.
This closes #208.
Sebastian