pull out _getTileURL (for extending) and added _getZoomForURL #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This did not work for me with min/maxNativeZoom. The reason is that getTileSize() must be overridden to adjust for the clamped zoom level. Without it, the requested tile coordinates don't match the required zoom level. See #69. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR pulls out the L.Util.Template call into its own _getTileURL function as well as implemented the TODO of using the _getZoomForURL.
This would allow a developer to extend the L.VectorGrid.Protobuf class and generate their own tile URL without having to follow the URL skeleton scheme or re-implementing the entire _getVectorTilePromise function.
If there are any changes to the code, or if this doesn't fit into the project, just let me know.
Thanks!