Changes for bubble heatmap rendenering #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…blem when intensity not present based on some code very kindly provided by github user jameslaneconkling. the code in L.heat that redraws the layers was multiplying intensities by a value related to the zoom level stored in a variable named v. v is typically a very small number, ranging from .008 to .00002. The code works better if it just uses the intensity value. Since I only provide points with an intensity value set, I'm not sure what happens when the intensity isn't set. The code probably breaks. This commit is not intended as a permanent fix. Instead, it highlights where the problem is. I hope someone that knows the code better considers re-organizing the render loop perhaps treating separating it into two distinct pieces: one for when intensities are provided and one where they are not.
may also contain code for ca1f430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't fully understand how the values are combined, but the change at line 149 works better for my heatmaps. Someone that understands the other use cases will likely have a better solution.
Optionally rendering all colors with the same transparency results in better heatmaps.