pixi/webgl/** touchup
#3022
Open
pixi/webgl/** touchup
#3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test results:
6 errors have been fixed. This comment will be automatically updated whenever you push a commit. |
LukeAbby
requested changes
Jan 15, 2025
| @@ -10,7 +10,12 @@ declare global { | |||
|
|
|||
| type PackInterleavedGeometryFunction = ToMethod< | |||
| ( | |||
| element: PIXI.IBatchableElement, | |||
| /** | |||
| * @privateRemarks IntentionalPartial to allow `DepthSamplerShader.DepthBatchData`, | |||
There was a problem hiding this comment.
It's more useful to explain why null isn't allowed imo.
There was a problem hiding this comment.
It's as it is because I don't know for sure anything about the nullability in PIXI.BatchRenderer._packInterleavedGeometry , I only have information about what keys are in use or not. I could go on a hunt, but I wouldn't be able to add notations to the keys coming from the PIXI interface anyway, so this seemed like the most correct I could for sure be.
src/foundry/client/pixi/webgl/shaders/filters/base-filter.d.mts
Outdated
Show resolved
Hide resolved
| @@ -19,6 +15,7 @@ declare class AdaptiveFragmentChannel { | |||
| * A factory method for creating the filter using its defined default values | |||
| * @param options - Options which affect filter construction | |||
| */ | |||
| //TODO: See if we can get this to return the mixed shader class, as it calls `super.create()` | |||
There was a problem hiding this comment.
We can look into this if you'd like.
There was a problem hiding this comment.
I would very much not like to think about FragmentChannelMixin for the rest of my life; it is too complicated for something that literally sees no use. Maybe this can be a side quest after v13 (still hoping v14 just yanks it).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganize all of
pixi/webgl/**to preferred order of classes and namespacesChange over to new
interface Anyfromtype AnyAdd tests for all shaders, extensions, and helpers
Fix enum issues from Brand conversions
General other touchup