feat: rework modpkg format #24
Conversation
Crauzer
commented
Nov 11, 2024
•
Crauzer
commented
- Create utils functions for modpkg
| let wad_paths: Vec<String> = rmp_serde::from_slice(&wad_paths)?; | ||
|
|
||
| let layers: Vec<String> = rmp_serde::from_slice(&layers)?; | ||
| if !layers.contains(&"base".to_string()) { |
There was a problem hiding this comment.
This check is not correct, need to fix
| return Err(ModpkgError::MissingBaseLayer); | ||
| } | ||
|
|
||
| let chunks = Self::read_chunks(reader, chunk_count)?; |
There was a problem hiding this comment.
i would appreciate if there was alignment check to make sure chunks are aligned to 8 here
not strictly required but it's a nice thing to do
|
btw I'm probably in favor of doing our own serialization for metadata and strings, there seem to be differences between msgpack libraries in how they handle enums for example, so I'd like to avoid potential issues there |
what about having metadata and strings table being just chunks instead of dedicated fields? |
Sure, I don't think it should cause too much trouble for the user |
