Avoid sending a status word twice on failure, which would cause an ap…

…p crash
LedgerHQ · Feb 5, 2024 · bdcbe1b · bdcbe1b
1 parent aac2e7a
commit bdcbe1b
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/handler/sign_psbt.c b/src/handler/sign_psbt.c
@@ -2473,10 +2473,12 @@ sign_transaction(dispatcher_context_t *dc,
                         return false;
 
                     if (!sign_transaction_input(dc, st, &hashes, &placeholder_info, &input, i)) {
-                        SEND_SW(dc, SW_BAD_STATE);  // should never happen
                         if (!G_swap_state.called_from_swap) {
                             ui_post_processing_confirm_transaction(dc, false);
                         }
+
+                        // we do not send a status word, since sign_transaction_input
+                        // already does it on failure
                         return false;
                     }
                 }