Add support for musig() key expressions by bigspider · Pull Request #230 · LedgerHQ/app-bitcoin-new

Added parsing for musig(); generalized key placeholders in wallet policies to more general key expressions

bigspider

committed

Rename "key placeholder" with "key expression" where appropriate; added some comments.

bigspider

committed

Refactored policy_node_keyexpr_t to explicitly label which of the union type is used; generalized some parts of the code that are not generalized to musig key expressions, and annotated some others.

bigspider

committed

Add PSBT constants related to MuSig2; deleted unused constant

bigspider

committed

Moved secp256k1 constants to a separate module

bigspider

committed

Added address generation tests for musig

bigspider

committed

Made crypto_tr_lift_x and crypto_tr_tagged_hash functions public

bigspider

committed

Musig key aggregation and address generation

bigspider

committed

Compute aggregate xpub for musig() in descriptors in the python client library

bigspider

committed

Add musig2 fields to PSBT class

bigspider

committed

Added python standalone implementation of MuSig2 signing, and tests

bigspider

committed

Add 'tweak' output parameter to bip32_CKDpub; exposed BIP341 constants

bigspider

committed

Add parsing of Musig2 pubnonces and partial signatures as yielded values in sign_psbt in the python client

bigspider

committed

MuSig2 signing, rounds 1 and 2

bigspider

committed

Update musig() specs, and fix psbt processing

bigspider

committed

Fix psbt-level musig signing session logic

bigspider

committed

Modularize and extract the musig session handling from sign_psbt.c

bigspider

committed

Persistent storage for musig psbt signing sessions

bigspider

committed

Add ragger navigation to musig sign_psbt tests

bigspider

committed

Update sanity checks for musig key expressions

bigspider

committed

Add architecture docs for MuSig2

bigspider

committed

Reference musig docs in musig session module

bigspider

committed

Add const qualifiers, and asserts guarding against overflows

bigspider

committed

Expose new types in python client

bigspider

committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for musig() key expressions#230

Commits on Jul 16, 2024

Added parsing for musig(); generalized key placeholders in wallet policies to more general key expressions

Rename "key placeholder" with "key expression" where appropriate; added some comments.

Refactored policy_node_keyexpr_t to explicitly label which of the union type is used; generalized some parts of the code that are not generalized to musig key expressions, and annotated some others.

Add PSBT constants related to MuSig2; deleted unused constant

Moved secp256k1 constants to a separate module

Added address generation tests for musig

Made crypto_tr_lift_x and crypto_tr_tagged_hash functions public

Musig key aggregation and address generation

Compute aggregate xpub for musig() in descriptors in the python client library

Add musig2 fields to PSBT class

Added python standalone implementation of MuSig2 signing, and tests

Add 'tweak' output parameter to bip32_CKDpub; exposed BIP341 constants

Add parsing of Musig2 pubnonces and partial signatures as yielded values in sign_psbt in the python client

MuSig2 signing, rounds 1 and 2

Update musig() specs, and fix psbt processing

Fix psbt-level musig signing session logic

Modularize and extract the musig session handling from sign_psbt.c

Persistent storage for musig psbt signing sessions

Add ragger navigation to musig sign_psbt tests

Update sanity checks for musig key expressions

Add architecture docs for MuSig2

Reference musig docs in musig session module

Add const qualifiers, and asserts guarding against overflows

Expose new types in python client