Merge pull request #171 from LedgerHQ/fbe/add_partner_info

Add partner name in screen

src/globals.h

@@ -39,7 +39,10 @@ extern uint8_t G_io_seproxyhal_spi_buffer[IO_SEPROXYHAL_BUFFER_SIZE_B];
 #define PARTNER_NAME_PREFIX_FOR_FUND "To "
 
 typedef struct partner_data_s {
-    char prefixed_name[sizeof(PARTNER_NAME_PREFIX_FOR_FUND) - 1 + MAX_PARTNER_NAME_LENGHT + 1];
+    union {
+        char unprefixed_name[MAX_PARTNER_NAME_LENGHT + 1];
+        char prefixed_name[sizeof(PARTNER_NAME_PREFIX_FOR_FUND) - 1 + MAX_PARTNER_NAME_LENGHT + 1];
+    };
     cx_ecfp_256_public_key_t public_key;
 } partner_data_t;
 

src/set_partner_key.c

@@ -73,14 +73,20 @@ int set_partner_key(const command_t *cmd) {
         return reply_error(err);
     }
 
-    memset(G_swap_ctx.partner.prefixed_name, 0, sizeof(G_swap_ctx.partner.prefixed_name));
-    // Prepare the prefix for FUND display
-    strlcpy(G_swap_ctx.partner.prefixed_name,
-            PARTNER_NAME_PREFIX_FOR_FUND,
-            sizeof(G_swap_ctx.partner.prefixed_name));
-    // The incoming partner name is NOT NULL terminated, so we use strncat
-    // Don't erase the prefix copied above
-    strncat(G_swap_ctx.partner.prefixed_name, (char *) partner.bytes, partner.size);
+    if (G_swap_ctx.subcommand == FUND || G_swap_ctx.subcommand == FUND_NG) {
+        // Prepare the prefix for FUND display
+        memset(G_swap_ctx.partner.prefixed_name, 0, sizeof(G_swap_ctx.partner.prefixed_name));
+        strlcpy(G_swap_ctx.partner.prefixed_name,
+                PARTNER_NAME_PREFIX_FOR_FUND,
+                sizeof(G_swap_ctx.partner.prefixed_name));
+        // The incoming partner name is NOT NULL terminated, so we use strncat
+        // Don't erase the prefix copied above
+        strncat(G_swap_ctx.partner.prefixed_name, (char *) partner.bytes, partner.size);
+    } else {
+        memset(G_swap_ctx.partner.unprefixed_name, 0, sizeof(G_swap_ctx.partner.unprefixed_name));
+        // The incoming partner name is NOT NULL terminated, so we use strncpy
+        strncpy(G_swap_ctx.partner.unprefixed_name, (char *) partner.bytes, partner.size);
+    }
 
     // Create the verifying key from the raw public key
     if (cx_ecfp_init_public_key_no_throw(curve,

src/ui/validate_transaction_bagl.c

@@ -22,88 +22,103 @@ static void on_reject(__attribute__((unused)) const bagl_element_t *e) {
 }
 
 // clang-format off
-UX_STEP_NOCB(ux_confirm_flow_1_step, pnn,
+UX_STEP_NOCB(step_1_all, pnn,
 {
     &C_icon_eye,
     "Review",
     "transaction",
 });
-UX_STEP_NOCB(ux_confirm_flow_1_2_step, bnnn_paging,
+UX_STEP_NOCB(step_2_not_fund, bnnn_paging,
+{
+    .title = "Exchange partner",
+    .text = G_swap_ctx.partner.unprefixed_name,
+});
+UX_STEP_NOCB(step_3_sell, bnnn_paging,
 {
     .title = "Email",
     .text = G_swap_ctx.sell_transaction.trader_email,
 });
-UX_STEP_NOCB(ux_confirm_flow_1_3_step, bnnn_paging,
+UX_STEP_NOCB(step_3_fund, bnnn_paging,
 {
     .title = "User",
     .text = G_swap_ctx.fund_transaction.user_id,
 });
-UX_STEP_NOCB(ux_confirm_flow_2_step, bnnn_paging,
+UX_STEP_NOCB(step_4_all, bnnn_paging,
 {
     .title = "Send",
     .text = G_swap_ctx.printable_send_amount,
 });
-UX_STEP_NOCB(ux_confirm_flow_3_step, bnnn_paging,
+UX_STEP_NOCB(step_5_fund, bnnn_paging,
+{
+    .title = G_swap_ctx.partner.prefixed_name,
+    .text = G_swap_ctx.account_name,
+});
+UX_STEP_NOCB(step_5_not_fund_fixed_rate, bnnn_paging,
 {
     .title = "Get",
     .text = G_swap_ctx.printable_get_amount,
 });
-UX_STEP_NOCB(ux_confirm_flow_3_floating_step, bnnn_paging,
+UX_STEP_NOCB(step_5_not_fund_floating_rate, bnnn_paging,
 {
     .title = "Get estimated",
     .text = G_swap_ctx.printable_get_amount,
 });
-UX_STEP_NOCB(ux_confirm_flow_3_2_step, bnnn_paging,
-{
-    .title = G_swap_ctx.partner.prefixed_name,
-    .text = G_swap_ctx.account_name,
-});
-UX_STEP_NOCB(ux_confirm_flow_4_step, bnnn_paging,
+UX_STEP_NOCB(step_6_all, bnnn_paging,
 {
     .title = "Fees",
     .text = G_swap_ctx.printable_fees_amount,
 });
-UX_STEP_CB(ux_confirm_flow_5_step, pbb, on_accept(NULL),
+UX_STEP_CB(step_7_all, pbb, on_accept(NULL),
 {
     &C_icon_validate_14,
     "Accept",
     "and send",
 });
-UX_STEP_CB(ux_confirm_flow_6_step, pb, on_reject(NULL),
+UX_STEP_CB(step_8_all, pb, on_reject(NULL),
 {
     &C_icon_crossmark,
     "Reject",
 });
 
 // clang-format on
-const ux_flow_step_t *ux_confirm_flow[8];
+
+// 8 steps max + FLOW_END_STEP
+const ux_flow_step_t *ux_confirm_flow[9];
 
 void ui_validate_amounts(void) {
     int step = 0;
 
-    ux_confirm_flow[step++] = &ux_confirm_flow_1_step;
+    ux_confirm_flow[step++] = &step_1_all;
+
+    if (G_swap_ctx.subcommand != FUND && G_swap_ctx.subcommand != FUND_NG) {
+        ux_confirm_flow[step++] = &step_2_not_fund;
+    }
 
     if (G_swap_ctx.subcommand == SELL || G_swap_ctx.subcommand == SELL_NG) {
-        ux_confirm_flow[step++] = &ux_confirm_flow_1_2_step;
+        ux_confirm_flow[step++] = &step_3_sell;
     } else if (G_swap_ctx.subcommand == FUND || G_swap_ctx.subcommand == FUND_NG) {
-        ux_confirm_flow[step++] = &ux_confirm_flow_1_3_step;
+        ux_confirm_flow[step++] = &step_3_fund;
     }
 
-    ux_confirm_flow[step++] = &ux_confirm_flow_2_step;
+    ux_confirm_flow[step++] = &step_4_all;
 
     if (G_swap_ctx.subcommand == FUND || G_swap_ctx.subcommand == FUND_NG) {
-        ux_confirm_flow[step++] = &ux_confirm_flow_3_2_step;
-    } else if (G_swap_ctx.rate == FLOATING) {
-        ux_confirm_flow[step++] = &ux_confirm_flow_3_floating_step;
+        ux_confirm_flow[step++] = &step_5_fund;
     } else {
-        ux_confirm_flow[step++] = &ux_confirm_flow_3_step;
+        if (G_swap_ctx.rate == FLOATING) {
+            ux_confirm_flow[step++] = &step_5_not_fund_floating_rate;
+        } else {
+            ux_confirm_flow[step++] = &step_5_not_fund_fixed_rate;
+        }
     }
 
-    ux_confirm_flow[step++] = &ux_confirm_flow_4_step;
-    ux_confirm_flow[step++] = &ux_confirm_flow_5_step;
-    ux_confirm_flow[step++] = &ux_confirm_flow_6_step;
+    ux_confirm_flow[step++] = &step_6_all;
+    ux_confirm_flow[step++] = &step_7_all;
+    ux_confirm_flow[step++] = &step_8_all;
     ux_confirm_flow[step++] = FLOW_END_STEP;
 
+    // /!\ Remember to update ux_confirm_flow size if adding steps
+
     ux_flow_init(0, ux_confirm_flow, NULL);
 }
 

src/ui/validate_transaction_nbgl.c

@@ -104,13 +104,19 @@ static void review_choice(bool confirm) {
     }
 }
 
-static nbgl_layoutTagValue_t pairs[4];
+static nbgl_layoutTagValue_t pairs[5];
 static nbgl_layoutTagValueList_t pair_list;
 static nbgl_pageInfoLongPress_t info_long_press;
 
 static void continue_review(void) {
     uint8_t index = 0;
 
+    if (G_swap_ctx.subcommand != FUND && G_swap_ctx.subcommand != FUND_NG) {
+        pairs[index].item = "Exchange partner";
+        pairs[index].value = G_swap_ctx.partner.unprefixed_name;
+        index++;
+    }
+
     if (G_swap_ctx.subcommand == SELL || G_swap_ctx.subcommand == SELL_NG) {
         pairs[index].item = "Email";
         pairs[index].value = G_swap_ctx.sell_transaction.trader_email;