Skip to content

Commit

Permalink
Merge pull request #196 from LedgerHQ/fbe/update_for_uploadv4_github_…
Browse files Browse the repository at this point in the history
…actions

Update for reusable workflow using actions/upload-artifact@v4
  • Loading branch information
fbeutin-ledger authored Jun 19, 2024
2 parents 2532859 + ecdca98 commit f6ebd6d
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/check_protobuf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:

steps:
- name: Clone
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
submodules: recursive

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/codeql-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:

steps:
- name: Clone
uses: actions/checkout@v3
uses: actions/checkout@v4
with:
submodules: recursive

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint-workflow.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

steps:
- name: Clone
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Lint
uses: DoozyX/[email protected]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/misspellings_checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Clone
uses: actions/checkout@v3
uses: actions/checkout@v4

- name: Check misspellings
uses: codespell-project/actions-codespell@v1
Expand Down
15 changes: 13 additions & 2 deletions .github/workflows/reusable_swap_functional_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,20 @@ jobs:
# Set the coin variant to build with COIN or CHAIN depending on the app + flags for ETH compilation
# As a rule of thumb we don't care about giving unexisting flags to other apps, it has no effect
flags: "COIN=${{ matrix.coin.name }} CHAIN=${{ matrix.coin.name }} CAL_TEST_KEY=1 DOMAIN_NAME_TEST_KEY=1 SET_PLUGIN_TEST_KEY=1 NFT_TEST_KEY=1"
upload_app_binaries_artifact: libraries_binaries
upload_app_binaries_artifact: libraries_binaries-${{ matrix.coin.name }}
upload_as_lib_artifact: ${{ matrix.coin.name }}

merge_libraries_build:
name: Merge built libraries
needs: build_sideloaded_applications
runs-on: ubuntu-latest
steps:
- uses: actions/upload-artifact/merge@v4
with:
name: libraries_binaries
pattern: libraries_binaries-*
delete-merged: true

build_exchange_application:
name: Build application using the reusable workflow
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_build.yml@v1
Expand All @@ -161,7 +172,7 @@ jobs:
name: Run ragger tests using the reusable workflow
needs:
- build_exchange_application
- build_sideloaded_applications
- merge_libraries_build
uses: LedgerHQ/ledger-app-workflows/.github/workflows/reusable_ragger_tests.yml@v1
with:
app_repository: LedgerHQ/app-exchange
Expand Down

0 comments on commit f6ebd6d

Please sign in to comment.