Swap cosmos support (#3) #244
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add cosmos support * add snapshots * add CI support
Comment on lines
+118
to
+125
| branch_for_cosmos: | ||
| required: false | ||
| default: 'main' | ||
| type: string | ||
| repo_for_cosmos: | ||
| required: false | ||
| default: 'cosmos/ledger-cosmos' | ||
| type: string |
There was a problem hiding this comment.
Fine for now, I'll change it to our fork once it's merged
| @@ -177,6 +186,9 @@ jobs: | |||
| - name: cardano | |||
| repo: ${{ inputs.repo_for_cardano }} | |||
| branch: ${{ inputs.branch_for_cardano }} | |||
| - name: cosmos | |||
There was a problem hiding this comment.
this will be used as COIN= value
Suggested change
| - name: cosmos | |
| - name: ATOM |
test/python/conftest.py
Outdated
| @@ -24,6 +24,7 @@ | |||
| "DOT": "Polkadot", | |||
| "tron": "Tron", | |||
| "ton": "TON", | |||
| "cosmos": "Cosmos", | |||
There was a problem hiding this comment.
Needs to be aligned with the value in the CI
Suggested change
| "cosmos": "Cosmos", | |
| "ATOM": "Cosmos", |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add cosmos support
add snapshots
add CI support
Checklist
develop