Small "bug" fix #59
Merged
Small "bug" fix #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpascal-ledger
force-pushed
the
hardening
branch
4 times, most recently
from
29c5a01 to
8d06dc7
Compare
lpascal-ledger
force-pushed
the
hardening
branch
from
8d06dc7 to
59f9c91
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some U2F services tends to send fake register request to check for a user presence.
While being discrete in most security keys, on Ledger devices this triggers the display of a register screen with gibberish, which also blocks the IOs which can cause the app to crash.
This PRs allows to recognize this specific request, and to immediately respond with an error.