Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚙️ (jfrog) [NO-ISSUE]: Attest and sign package #316

Closed
wants to merge 3 commits into from

Conversation

dedsxc
Copy link
Contributor

@dedsxc dedsxc commented Sep 23, 2024

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bugfixes, you can explain the previous behavior and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

✅ Checklist

Pull Requests must pass the CI and be code reviewed. Set as Draft if the PR is not ready.

  • Covered by automatic tests.
  • Changeset is provided
  • Impact of the changes:
    • ...

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

Copy link

vercel bot commented Sep 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 7:33am

Copy link
Contributor

github-actions bot commented Sep 23, 2024

Messages
Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against d5c5d4c

Copy link
Member

@AEnguerrand AEnguerrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (on supply chain security side)

@dedsxc dedsxc force-pushed the fix/no-issue-jfrog-attest-sign-package branch from 5fe7f42 to d5c5d4c Compare September 24, 2024 07:32
@dedsxc dedsxc closed this Sep 24, 2024
@dedsxc dedsxc deleted the fix/no-issue-jfrog-attest-sign-package branch September 24, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants