Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 (repo) [NO-ISSUE]: Trigger PR tests after toolchain update #420

Merged

Conversation

valpinkman
Copy link
Member

@valpinkman valpinkman commented Oct 16, 2024

📝 Description

Since the update-toolchain.yml workflow uses a GIHTUB_TOKEN to create the PR, the CI for the PR workflow is not run (security measure to prevent a infinite loops)
Thus I added the test directly in the workflow that does the update, meaning the PR won't have any checks, but the test will be passed before the PR is created, so we can safely merge it.
However, if we need to rebase the created PR (chore/update-toolchain), the CI will trigger as usual so no issues there

❓ Context

  • JIRA or GitHub link:
  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@valpinkman valpinkman requested a review from a team as a code owner October 16, 2024 14:24
Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 16, 2024 3:15pm

Copy link
Contributor

github-actions bot commented Oct 16, 2024

Messages
⚠️ No changeset file found in the PR. Please add a changeset file.

Generated by 🚫 dangerJS against 23e2a9d

@valpinkman valpinkman force-pushed the chore/no-issue-trigger-workflow-after-toolchain-update branch from 7063574 to e0b9370 Compare October 16, 2024 14:25
@valpinkman valpinkman marked this pull request as draft October 16, 2024 14:32
@valpinkman valpinkman force-pushed the chore/no-issue-trigger-workflow-after-toolchain-update branch from e0b9370 to 660c257 Compare October 16, 2024 14:44
@valpinkman valpinkman force-pushed the chore/no-issue-trigger-workflow-after-toolchain-update branch from 660c257 to ae19f4a Compare October 16, 2024 14:56
@valpinkman valpinkman force-pushed the chore/no-issue-trigger-workflow-after-toolchain-update branch from ae19f4a to 76e2386 Compare October 16, 2024 15:08
@valpinkman valpinkman force-pushed the chore/no-issue-trigger-workflow-after-toolchain-update branch from 76e2386 to 23e2a9d Compare October 16, 2024 15:13
@valpinkman valpinkman marked this pull request as ready for review October 16, 2024 15:37
@valpinkman valpinkman merged commit a692c5f into develop Oct 17, 2024
16 checks passed
@valpinkman valpinkman deleted the chore/no-issue-trigger-workflow-after-toolchain-update branch October 17, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants