Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (signer-solana) [DSDK-565]: Implement SignTransaction usecase #489

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

✨ (signer-solana) [DSDK-565]: Implement SignTransaction usecase #489

wants to merge 3 commits into from
+1,006 −206

Conversation

aussedatlo
Copy link
Contributor

@aussedatlo aussedatlo commented Nov 12, 2024 •
edited by jira bot
Loading

📝 Description

Add Sign Transaction Use case in sample and Solana signer kit.

Screen.Recording.2024-11-12.at.17.24.06.mov

❓ Context

  • JIRA or GitHub link:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@aussedatlo aussedatlo requested a review from a team as a code owner November 12, 2024 16:25
@vercel Vercel
Copy link

vercel bot commented Nov 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 4:26pm
doc-device-management-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 4:26pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 12, 2024 •
edited
Loading

Messages
✅ Danger: All checks passed successfully! 🎉

Generated by 🚫 dangerJS against 21bdf9e

valpinkman
valpinkman reviewed Nov 12, 2024
View reviewed changes
...signer-solana/src/internal/app-binder/device-action/__test-utils__/testDeviceActionStates.ts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ASK] Is this a copy of the testDeviceActions in dmk ? If we reuse it everywhere, it might be worth to export it in the DMK

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this is a copy from the ethereum signer. It would not be strange to export it from the public DMK api as it's used only for internal test ?

Copy link
Member

@valpinkman valpinkman Nov 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be used by external devs who wants to implement other DeviceActions to have the test utils.

It's definitely non blocking for this PR and I will approve. However I'm thinking that we could have a test-utils packages that could be reuse by the dmk and the other packages. WDYT ?

Or we could make it an internal util package

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I think it could be interesting to have something like this !

valpinkman
valpinkman reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@valpinkman valpinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, not validating now as I'd like to have your feedback on my comments first 🙏

@aussedatlo aussedatlo force-pushed the feat/dsdk-565-signer-solana-sign-transaction-usecase branch from 5b28966 to 2eabc3e Compare November 13, 2024 13:19
@aussedatlo aussedatlo force-pushed the feat/dsdk-565-signer-solana-sign-transaction-usecase branch from 2eabc3e to 21bdf9e Compare November 13, 2024 16:24
@aussedatlo aussedatlo added this pull request to the merge queue Nov 14, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valpinkman valpinkman valpinkman approved these changes

Assignees

@aussedatlo aussedatlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aussedatlo @valpinkman