Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’š (ci) [NO-ISSUE]: Node upgrade #517

Closed
wants to merge 2 commits into from

Conversation

jdabbech-ledger
Copy link
Contributor

πŸ“ Description

According to this jest issue, node upgrade to v21 fixes the memory consumption issues that we encounter with jest coverage in CI

❓ Context

  • JIRA or GitHub link: [NO-ISSUE]
  • Feature:

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@jdabbech-ledger jdabbech-ledger requested a review from a team as a code owner November 22, 2024 13:19
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Nov 22, 2024 1:37pm
doc-device-management-kit ❌ Failed (Inspect) Nov 22, 2024 1:37pm

Copy link
Contributor

github-actions bot commented Nov 22, 2024

Messages
⚠️ No changeset file found in the PR. Please add a changeset file.

Generated by 🚫 dangerJS against db8e9d5

@jdabbech-ledger jdabbech-ledger added invalid This doesn't seem right hodl Do not merge labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hodl Do not merge invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants