Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔖 (hotfix) [NO-ISSUE]: DMK v0.5.1 + Transport Mock Client v1.1.0 #520

Merged
merged 3 commits into from
Nov 22, 2024

Conversation

valpinkman
Copy link
Member

📝 Description

Hotfix for DMK 0.5.0 which requires @ledgerhq/device-transport-kit-mock-client in its dependencies but was private.
Updatng @ledgerhq/device-transport-kit-mock-client to public and publishing a new version of DMK (0.5.1)

❓ Context

  • JIRA or GitHub link: [NO-ISSUE]
  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@valpinkman valpinkman requested a review from a team as a code owner November 22, 2024 15:58
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:10pm
doc-device-management-kit ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2024 4:10pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants