Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ”– (eth) [NO-ISSUE]: Signer Eth v1.1.1 + Context module v1.1.0 #553

Merged
merged 84 commits into from
Dec 11, 2024

Conversation

jdabbech-ledger
Copy link
Contributor

πŸ“ Description

Minor release of signer-eth package

❓ Context

  • JIRA or GitHub link: [NO-ISSUE]
  • Feature:

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

mbertin-ledger and others added 30 commits November 8, 2024 15:40
Also exported the factories to make it easier to pass to addTransport
…ers - Improve typeguards to not rely on instanceof (#508)
valpinkman and others added 25 commits December 2, 2024 17:45
@jdabbech-ledger jdabbech-ledger requested a review from a team as a code owner December 11, 2024 11:23
Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 11, 2024 11:23am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Dec 11, 2024 11:23am

Copy link
Member

@valpinkman valpinkman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jdabbech-ledger jdabbech-ledger merged commit 2cbe039 into main Dec 11, 2024
6 of 7 checks passed
@jdabbech-ledger jdabbech-ledger deleted the release branch December 11, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants