🐛 (context-module) [DSDK-615]: Iterate on transaction calldata #563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
jiyuzhuang
reviewed
Dec 16, 2024
| const calldataDescriptor = | ||
| calldata.descriptors_calldata?.[address]?.[selector]; | ||
| if (!calldataDescriptor) { | ||
| if (!Array.isArray(dto)) { |
There was a problem hiding this comment.
It's better to check the array length as well and add a test case for it. The return in line 76 and at the end of the loop have the same message, I think it's better to clarify / differentiate the known error at early step (not an array or empty), which can also help us locate where the problem is in real use case.
aussedatlo
force-pushed
the
fix/dsdk-615-handle-empty-calldata
branch
from
186e724 to
62d0721
Compare
jiyuzhuang
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Iterate on transaction calldata descriptors to avoid empty objects.
❓ Context
✅ Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
🧐 Checklist for the PR Reviewers