-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β¨ (signer-btc) [DSDK-482]: Implement sign message #564
β¨ (signer-btc) [DSDK-482]: Implement sign message #564
Conversation
The latest updates on your projects. Learn more about Vercel for Git βοΈ
1 Skipped Deployment
|
2bca7ac
to
d3e2719
Compare
d3e2719
to
cc784d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work for the client command handlers π
Look forward to rebase on it for the sign psbt task, with a few refactor in order to separate and reuse the client commands loop actually implemented in sign message task
cc784d5
to
6987863
Compare
Just A reminder: the screen display on device (Flex in your example) is unique now, the second one with the rond button at the bottom left is the chosen one. Maybe this is not related to the tickets in this PR. |
π Description
This is the agglomerated giga-PR for sign message in BTC signer.
It includes:
β Checklist
Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.
π§ Checklist for the PR Reviewers