Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (signer-btc) [DSDK-482]: Implement sign message #564

Conversation

fAnselmi-Ledger
Copy link
Contributor

@fAnselmi-Ledger fAnselmi-Ledger commented Dec 16, 2024

πŸ“ Description

This is the agglomerated giga-PR for sign message in BTC signer.

It includes:

ScreenRecording2024-12-16

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

Copy link

vercel bot commented Dec 16, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 16, 2024 2:15pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Dec 16, 2024 2:15pm

Copy link
Contributor

github-actions bot commented Dec 16, 2024

Messages
βœ… Danger: All checks passed successfully! πŸŽ‰

Generated by 🚫 dangerJS against 6987863

@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/DSDK-477-ts-signer-implement-sign-message-deviceAction branch from 2bca7ac to d3e2719 Compare December 16, 2024 10:31
@fAnselmi-Ledger fAnselmi-Ledger changed the title ✨ {signer-btc) implement sign message ✨ {signer-btc) [DSDK-482]: implement sign message Dec 16, 2024
@fAnselmi-Ledger fAnselmi-Ledger changed the title ✨ {signer-btc) [DSDK-482]: implement sign message ✨ (signer-btc) [DSDK-482]: implement sign message Dec 16, 2024
@fAnselmi-Ledger fAnselmi-Ledger changed the title ✨ (signer-btc) [DSDK-482]: implement sign message ✨ (signer-btc) [DSDK-482]: Implement sign message Dec 16, 2024
@fAnselmi-Ledger fAnselmi-Ledger force-pushed the feat/DSDK-477-ts-signer-implement-sign-message-deviceAction branch from d3e2719 to cc784d5 Compare December 16, 2024 13:37
@fAnselmi-Ledger fAnselmi-Ledger marked this pull request as ready for review December 16, 2024 13:57
@fAnselmi-Ledger fAnselmi-Ledger requested a review from a team as a code owner December 16, 2024 13:57
Copy link
Contributor

@jdabbech-ledger jdabbech-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work for the client command handlers πŸ‘
Look forward to rebase on it for the sign psbt task, with a few refactor in order to separate and reuse the client commands loop actually implemented in sign message task

@jiyuzhuang
Copy link
Contributor

Just A reminder: the screen display on device (Flex in your example) is unique now, the second one with the rond button at the bottom left is the chosen one. Maybe this is not related to the tickets in this PR.

@fAnselmi-Ledger fAnselmi-Ledger added this pull request to the merge queue Dec 16, 2024
Merged via the queue into develop with commit 633ed6f Dec 16, 2024
10 checks passed
@fAnselmi-Ledger fAnselmi-Ledger deleted the feat/DSDK-477-ts-signer-implement-sign-message-deviceAction branch December 16, 2024 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants