Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 (signer-eth) [DSDK-616]: Fallback to blind sign if provide in error #566

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

aussedatlo
Copy link
Contributor

@aussedatlo aussedatlo commented Dec 18, 2024

πŸ“ Description

Fallback to blind sign if provide in error to avoid getting stuck when the clear signing is not working correctly or a plugin is not installed.

❓ Context

  • Feature:

βœ… Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@aussedatlo aussedatlo requested a review from a team as a code owner December 18, 2024 08:31
Copy link

vercel bot commented Dec 18, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Dec 19, 2024 4:31pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:31pm

Copy link
Contributor

github-actions bot commented Dec 18, 2024

Messages
βœ… Danger: All checks passed successfully! πŸŽ‰

Generated by 🚫 dangerJS against 2bcb40d

@aussedatlo aussedatlo force-pushed the fix/dsdk-616-blind-signing-fallback branch from 477c910 to 2bcb40d Compare December 19, 2024 16:25
Copy link
Contributor

@paoun-ledger paoun-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@aussedatlo aussedatlo added this pull request to the merge queue Dec 20, 2024
Merged via the queue into develop with commit fc4ddf0 Dec 20, 2024
10 checks passed
@aussedatlo aussedatlo deleted the fix/dsdk-616-blind-signing-fallback branch December 20, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants