Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS][LDMK] Implement a websocket data source. #571

Closed
wants to merge 1 commit into from

Conversation

jiyuzhuang
Copy link
Contributor

Regarding how secure channel should be handle, create a component that will handle the websocket lifecyle (open, receive, close)

@jiyuzhuang jiyuzhuang requested a review from a team as a code owner December 19, 2024 01:53
@jiyuzhuang jiyuzhuang self-assigned this Dec 19, 2024
@jiyuzhuang jiyuzhuang closed this Dec 19, 2024
Copy link
Contributor

Fails
🚫

One or more commit message does not match the convention, see CONTRIBUTING.md.

Wrong commit messages:
✨ feat(tools): not a valid commit

ℹ️ Regex to match: /^.+\(([a-z]+\-?){1,}\): [A-Z].*/

  • Rules:
    • Must start with a word (usually an emoji)
    • Followed by a SPACE
    • Followed by a scope in parentheses and in LOWERCASE
    • Followed by a colon (":") and a SPACE
    • Followed by a Capitalized message

Example: 💚 (scope): My feature

🚫

Please fix the PR title to match the convention, see CONTRIBUTING.md.

Wrong PR title: [TS][LDMK] Implement a websocket data source.

ℹ️ Regex to match: /^.+ \(([a-z]+\-?){1,}\) \[(DSDK-[0-9]+|NO-ISSUE|ISSUE-[0-9]+)\]: [A-Z].*/

  • Rules:
    • Must start with a word (usually an emoji)
    • Followed by a SPACE
    • Followed by a scope in parentheses and in LOWERCASE
    • Followed by a SPACE
    • Followed by a JIRA issue number or NO-ISSUE or ISSUE- in [brackets] (uppercase)
    • Followed by a colon (":") and a SPACE
    • Followed by a Capitalized message

ℹ️ Example: ✨ (scope) [DSDK-1234]: My feature

Messages
⚠️ No changeset file found in the PR. Please add a changeset file.

Generated by 🚫 dangerJS against b26382b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant