Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ (dmk) [NO-ISSUE]: Add type check #592

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

jiyuzhuang
Copy link
Contributor

📝 Description

This fix aims to resolve the issue in this dependabot PR by adding a type check of buffer variable to ensure it's an ArrayBuffer.

❓ Context

  • JIRA or GitHub link: [NO-ISSUE]
  • Feature:

✅ Checklist

Pull Requests must pass CI checks and undergo code review. Set the PR as Draft if it is not yet ready for review.

  • Covered by automatic tests
  • Changeset is provided
  • Impact of the changes:
    • list of the changes

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.

@jiyuzhuang jiyuzhuang requested a review from a team as a code owner January 6, 2025 17:06
Copy link

vercel bot commented Jan 6, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
device-sdk-ts-sample ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 7, 2025 4:03pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
doc-device-management-kit ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 4:03pm

Copy link
Contributor

github-actions bot commented Jan 6, 2025

Messages
⚠️ No changeset file found in the PR. Please add a changeset file.

Generated by 🚫 dangerJS against 837b301

@jiyuzhuang jiyuzhuang changed the title 🚑 (web-ble): Add type check 🚑 (web-ble) [NO-ISSUE] : Add type check Jan 6, 2025
@jiyuzhuang jiyuzhuang marked this pull request as draft January 6, 2025 17:07
@jiyuzhuang jiyuzhuang marked this pull request as ready for review January 6, 2025 17:08
@jiyuzhuang jiyuzhuang force-pushed the fix/no-issue-add-typecheck branch from d23a30f to ffa7470 Compare January 6, 2025 17:09
@jiyuzhuang jiyuzhuang changed the title 🚑 (web-ble) [NO-ISSUE] : Add type check 💚 (web-ble) [NO-ISSUE] : Add type check Jan 6, 2025
@jiyuzhuang jiyuzhuang force-pushed the fix/no-issue-add-typecheck branch from ffa7470 to 837b301 Compare January 7, 2025 16:02
@jiyuzhuang jiyuzhuang changed the title 💚 (web-ble) [NO-ISSUE] : Add type check ♻️ (dmk) [NO-ISSUE] : Add type check Jan 7, 2025
@jiyuzhuang jiyuzhuang changed the title ♻️ (dmk) [NO-ISSUE] : Add type check ♻️ (dmk) [NO-ISSUE]: Add type check Jan 7, 2025
@jiyuzhuang jiyuzhuang marked this pull request as draft January 7, 2025 16:10
@jiyuzhuang jiyuzhuang marked this pull request as ready for review January 7, 2025 16:10
@jiyuzhuang jiyuzhuang added this pull request to the merge queue Jan 7, 2025
Merged via the queue into develop with commit 0226ac5 Jan 7, 2025
13 of 16 checks passed
@jiyuzhuang jiyuzhuang deleted the fix/no-issue-add-typecheck branch January 7, 2025 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants