Skip to content

Commit

Permalink
Update ledgerctl
Browse files Browse the repository at this point in the history
  • Loading branch information
@yogh333
yogh333 committed Sep 9, 2024
1 parent e8fd2eb commit 74fb1c7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,11 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.36.0] - 2024-09-09

### Changed
- Bump ledgerctl version

## [3.35.0] - 2024-09-09

### Changed
Expand Down
2 changes: 1 addition & 1 deletion full/Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ RUN apk add -t python_build_deps python3-dev \
libffi-dev

# Install ledgerctl, which is used by cargo ledger for loading or dumping an APDU app file.
RUN pip3 install ledgerwallet==0.5.0
RUN pip3 install ledgerwallet==0.5.1

Check warning on line 40 in full/Dockerfile

View check run for this annotation

Ledger Wiz (CSPM & secret detection) / Wiz IaC Scanner

Pip install keeping cached packages 

Rule ID: 825ae084-a21d-4595-9378-0b5b9edbc4d1
Severity: Medium
Resource: FROM={{ghcr.io/ledgerhq/ledger-app-builder/ledger-app-builder-lite:latest}}.{{pip3 install ledgerwallet==0.5.1}}

When installing packages with pip, the '--no-cache-dir' flag should be set to make Docker images smaller
Raw output 
Expected: The '--no-cache-dir' flag should be set when running 'pip/pip3 install'
Found: The '--no-cache-dir' flag isn't set when running 'pip/pip3 install'

# Cleanup, remove packages that aren't needed anymore
RUN apk del python_build_deps
Expand Down

0 comments on commit 74fb1c7

Please sign in to comment.