update nightly from nightly-2022-12-02 to nightly-2023-11-10

[yogh333]

No description provided.

[xchapron-ledger]

I'm not used to nightly Rust toolchain, but isn't the 2023-12-20 a bit too recent to bit used in production for app deployment?

[yogh333]

@xchapron-ledger TBH I do not know. We may also argue that an old nightly may have some issues that have been fixed by a more recent one. For your information, with this nightly, I have been able to compile and run CI tests with app-boilerplate-rust. I also propose to test every day the last nightly with the boilerplate app in order to detect any regression in nightly as soon as possible: LedgerHQ/app-boilerplate-rust#43. We may also perform the same with the Rust SDK (build + unit and integration tests), so we could track closely any new nightly releases.

[yogh333]

@yhql @agrojean-ledger what are your thoughts ? I think that we must update the nightly version in any case, and I have picked up the 2023-12-20 one because it was the last one when performing my test. I think we can start with this version at least, then discussing about when and how we decide to update the nightly version could come in a second phase.

[agrojean-ledger]

@yhql @agrojean-ledger what are your thoughts ? I think that we must update the nightly version in any case, and I have picked up the 2023-12-20 one because it was the last one when performing my test. I think we can start with this version at least, then discussing about when and how we decide to update the nightly version could come in a second phase.

Did you try to build the Rust boilerplate app and run functional tests with this nightly ? @yogh333

[xchapron-ledger]

Last time, I think that we choose a nightly corresponding to a stable release. I'd say this probably helps understanding what's in it (like in term of feature, but also in potential bug if some are tracked on the associated stable release). So maybe we could go this way again if it makes sense?

[yogh333]

@agrojean-ledger yes, please see this comment

@xchapron-ledger yes it's a good idea. For your information, Rust development operates on a train schedule. A stable release is released every six weeks from a fork (beta release) of the master branch. More information here. According to https://releases.rs/, the last beta release (1.76 beta, current stable release is 1.75) has been forked from master on 22 December, 2023. So let's go with nightly-2023-12-22 if everyone agrees. Building and testing the boilerplate with this nightly is the first step, then performing the "migration" (+ use of the "new" Rust SDK) of all current Rust apps may be the second one.

[yhql]

I think if we want to minimize the risk of bugs we should probably aim for a 'stable-like' release like you point out with the 1.75 (thanks for the link on releases.rs, very helpful). So that would be 2023-11-20 instead ?

[yogh333]

Ok will have a try with the nightly 2023-11-10 (from which stable 1.75 has been released). For your info, with nightly-2023-12-22 I have an issue with app-boilerplate-rust on Nano S when displaying public address to be confirmed: no APDU is returned and the test is stuck. No issue with Nano S+ or Nano X.

[yogh333]

Hi,

I think that we can switch to this new nightly. It has been tested with app-boilerplate-rust (branch test/mutlifield_review_refactor which fixes the stack overflow issue) here => Build and tests are ✅
I have removed the global sparse_registry option as it is now useless when using this nightly (already integrated).

WDYT ?