Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove invalid workspace-wide configuration #154

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

yhql
Copy link
Contributor

@yhql yhql commented May 3, 2024

This top-level configuration applies to all crates in the workspace, but it was invalid for the ones that are not meant to compile as an embedded app. (see https://doc.rust-lang.org/cargo/reference/config.html#hierarchical-structure "At present, when being invoked from a workspace, Cargo does not read config files from crates within the workspace")

cargo install --path cargo-ledger works again from the workspace with this fix

@yhql yhql requested review from kingofpayne and yogh333 May 3, 2024 18:26
@kingofpayne
Copy link
Contributor

I confirm installing cargo-ledger works by removing .cargo/config.toml

@yogh333 yogh333 force-pushed the yhql/fix_cargo_ledger_install branch from f77dc9b to 79506cb Compare June 14, 2024 08:39
@yogh333 yogh333 merged commit 40cc4c2 into master Jun 14, 2024
42 of 43 checks passed
@yogh333 yogh333 deleted the yhql/fix_cargo_ledger_install branch June 14, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants