Skip to content
This repository has been archived by the owner on Jun 16, 2022. It is now read-only.

WalletConnect - Ethereum Goerli in dev mode #4988

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bberz-groma
Copy link

@bberz-groma bberz-groma commented May 23, 2022

🦒 Context (issues, jira)

  • Adds logic to AccountHeaderActions.js to determine if developer mode is enabled
  • If enabled, test nets can be added to a walletConnectNetworks array that consists of the baseNetworks (["ethereum", "bsc", "polygon"];). In this PR, the networks would be ["ethereum", "bsc", "polygon", "ethereum_ropsten", "ethereum_goerli"];

💻 Description / Demo (image or video)

walletconnect-devmode.mov

🖤 Expectations to reach

PR must pass CI, rebase develop if conflicts. Thanks!

  • on QA: at least one of these two checkboxes must be checked:
    • a specific test planned is defined on Jira
    • this PR is covered by automatic UI test
  • on delivery: at least one of these two checkboxes must be checked:
    • Option 1: no impact: The changes of this PR have ZERO impact on the userland (invisible for users)
    • Option 2: atomic delivery: the changes is atomic and complete (no partial delivery)

@bberz-groma bberz-groma requested a review from a team as a code owner May 23, 2022 17:44
- if enabled, allow for goerli test net to exist for WalletConnect local testing.
@bberz-groma bberz-groma force-pushed the feature/walletconnect-devmode branch from 2584248 to c3d9e50 Compare May 23, 2022 17:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant