fix(lld): fix the default mac build by signing it

(Simply by leaving `CSC_IDENTITY_AUTO_DISCOVER` to true)
LedgerHQ · Jan 7, 2025 · e2b45f6 · e2b45f6
1 parent 3d51147
commit e2b45f6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/...-live-desktop/electron-builder-nosign.yml → ...e-desktop/electron-builder-nonotarize.yml b/...-live-desktop/electron-builder-nosign.yml → ...e-desktop/electron-builder-nonotarize.yml
@@ -5,8 +5,8 @@ protocols:
   schemes:
     - ledgerlive
 
-afterPack: scripts/afterPack.js
 beforePack: scripts/beforePack.js
+afterPack: scripts/afterPack.js
 
 mac:
   artifactName: ${name}-${version}-${os}.${ext}

diff --git a/apps/ledger-live-desktop/package.json b/apps/ledger-live-desktop/package.json
@@ -17,7 +17,7 @@
   "scripts": {
     "start:prod": "electron ./.webpack/main.bundle.js",
     "start": "cross-env NODE_ENV=development node ./tools/main.js",
-    "build": "cross-env CSC_IDENTITY_AUTO_DISCOVERY=false STAGING=1 node ./tools/dist --nosign -v",
+    "build": "cross-env STAGING=1 node ./tools/dist --nonotarize -v",
     "build:js": "cross-env NODE_ENV=production node ./tools/main.js build",
     "build:testing": "cross-env NODE_ENV=production TESTING=1 node ./tools/main.js build",
     "build:staging": "cross-env NODE_ENV=production STAGING=1 node ./tools/main.js build",

diff --git a/apps/ledger-live-desktop/tools/dist/index.js b/apps/ledger-live-desktop/tools/dist/index.js
@@ -122,9 +122,8 @@ const buildTasks = args => [
       } else if (args.pre) {
         commands.push("--config");
         commands.push("electron-builder-pre.yml");
-      } else if (args.nosign) {
-        commands.push("--config");
-        commands.push("electron-builder-nosign.yml");
+      } else if (args.nonotarize) {
+        commands.push("--config", "electron-builder-nonotarize.yml");
         commands.push("-c.afterSign='lodash/noop'");
         commands.push("--publish", "never");
       }
@@ -242,7 +241,7 @@ yargs
           type: "boolean",
           describe: "make it a release build",
         })
-        .option("nosign", {
+        .option("nonotarize", {
           type: "boolean",
         })
         .option("dirty", {