Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency electron-updater to v6.3.0 [security] #8023

Closed

Conversation

live-github-bot[bot]
Copy link
Contributor

This PR contains the following updates:

Package Type Update Change
electron-updater (source) dependencies minor 6.1.8 -> 6.3.0

GitHub Vulnerability Alerts

CVE-2024-39698

Observations

The file packages/electron-updater/src/windowsExecutableCodeSignatureVerifier.ts implements the signature validation routine for Electron applications on Windows. It executes the following command in a new shell (process.env.ComSpec on Windows, usually C:\Windows\System32\cmd.exe):

https://github.com/electron-userland/electron-builder/blob/140e2f0eb0df79c2a46e35024e96d0563355fc89/packages/electron-updater/src/windowsExecutableCodeSignatureVerifier.ts#L35-L41

Because of the surrounding shell, a first pass by cmd.exe expands any environment variable found in command-line above.

Exploitation

This creates a situation where verifySignature() can be tricked into validating the certificate of a different file than the one that was just downloaded. If the step is successful, the malicious update will be executed even if its signature is invalid.

Impact

This attack assumes a compromised update manifest (server compromise, Man-in-the-Middle attack if fetched over HTTP, Cross-Site Scripting to point the application to a malicious updater server, etc.).

Patch

This vulnerability was patched in #​8295, by comparing the path in the output of Get-AuthenticodeSignature with the intended one. The patch is available starting from 6.3.0-alpha.6.


Release Notes

electron-userland/electron-builder (electron-updater)

v6.3.0

Compare Source

Minor Changes
Patch Changes

v6.2.1

Compare Source

Patch Changes

v6.2.0

Compare Source

Minor Changes

v6.1.9

Compare Source

Patch Changes

Configuration

📅 Schedule: Branch creation - "" in timezone Europe/Paris, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

Copy link

vercel bot commented Oct 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-docs ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 10:14pm
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 10:14pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 10:14pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 10:14pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Oct 29, 2024 10:14pm

@live-github-bot live-github-bot bot force-pushed the renovate/npm-electron-updater-vulnerability branch 2 times, most recently from d6b12e0 to 5a32309 Compare October 17, 2024 22:07
@live-github-bot live-github-bot bot changed the title fix(deps): update dependency electron-updater to v6.3.0 [security] Update dependency electron-updater to v6.3.0 [SECURITY] Oct 17, 2024
@live-github-bot live-github-bot bot changed the title Update dependency electron-updater to v6.3.0 [SECURITY] fix(deps): update dependency electron-updater to v6.3.0 [security] Oct 18, 2024
@live-github-bot live-github-bot bot force-pushed the renovate/npm-electron-updater-vulnerability branch from 5a32309 to d93fe9a Compare October 24, 2024 22:10
@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Oct 24, 2024
@live-github-bot live-github-bot bot force-pushed the renovate/npm-electron-updater-vulnerability branch from d93fe9a to 5ea2da0 Compare October 29, 2024 22:08
Copy link

There as been no activity on this PR for the last 14 days. Please consider closing this PR.

@github-actions github-actions bot added the Stale label Nov 18, 2024
@github-actions github-actions bot closed this Nov 30, 2024
@live-github-bot
Copy link
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (6.3.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@live-github-bot live-github-bot bot deleted the renovate/npm-electron-updater-vulnerability branch December 2, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant