Call release-final
from release-prepare
workflows
#8718
Merged
+23
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket here
This changes the release workflows such that we now explicitly call
release-final
fromrelease-prepare
workflows, passing aref
input as we do so. The automatic follow-onworkflow_run
trigger is removed in this PR, meaning thatinputs.ref
is now guaranteed to be available in the workflow (passing inputs is not possible with theworkflow_run
trigger). This solves the issue seen in the above ticket.A side-effect of this approach is we won't be able to see these follow-on runs of
release-final
in the workflow history forrelease-final
, seen as the workflow was called byrelease-prepare
orrelease-prepare-hotfix
. Runtime/failures/successes will be attributed to therelease-prepare
orrelease-prepare-hotfix
workflow, making it a little harder to monitor/audit the runs IMO.(An alternative fix to this problem is #8713, however I'm closing that PR and going with this PR's approach instead because the
workflow_run
trigger is so limited [can't specify branch, can't pass inputs]).Testing
Test PR here:
release-prepare
release-final
is calledinputs.ref
and the checkout step proceeds smoothlyrelease-prepare-hotfix
instead ofrelease-prepare
🟢 Passing - see this comment