Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call release-final from release-prepare workflows #8718

Merged

Conversation

angusbayley
Copy link
Contributor

@angusbayley angusbayley commented Dec 17, 2024

Ticket here

This changes the release workflows such that we now explicitly call release-final from release-prepare workflows, passing a ref input as we do so. The automatic follow-on workflow_run trigger is removed in this PR, meaning that inputs.ref is now guaranteed to be available in the workflow (passing inputs is not possible with the workflow_run trigger). This solves the issue seen in the above ticket.

A side-effect of this approach is we won't be able to see these follow-on runs of release-final in the workflow history for release-final, seen as the workflow was called by release-prepare or release-prepare-hotfix. Runtime/failures/successes will be attributed to the release-prepare or release-prepare-hotfix workflow, making it a little harder to monitor/audit the runs IMO.

(An alternative fix to this problem is #8713, however I'm closing that PR and going with this PR's approach instead because the workflow_run trigger is so limited [can't specify branch, can't pass inputs]).

Testing

Test PR here:

  • run release-prepare
  • ensure release-final is called
  • ensure it echos out the correct value for inputs.ref and the checkout step proceeds smoothly
  • repeat for release-prepare-hotfix instead of release-prepare

🟢 Passing - see this comment

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 17, 2024 1:24pm
native-ui-storybook ⬜️ Ignored (Inspect) Dec 17, 2024 1:24pm
react-ui-storybook ⬜️ Ignored (Inspect) Dec 17, 2024 1:24pm
web-tools ⬜️ Ignored (Inspect) Dec 17, 2024 1:24pm

@angusbayley angusbayley merged commit 7fe5f18 into develop Dec 18, 2024
43 of 45 checks passed
@angusbayley angusbayley deleted the support/fix-release-ref-handling-call-from-first-workflow branch December 18, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation CI/CD stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants