Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/live 15126 aptos unit tests bride boradcast prepare transactions #8742

Conversation

may01
Copy link
Contributor

@may01 may01 commented Dec 19, 2024

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

unit tests for:

  • libs/ledger-live-common/src/families/aptos/bridge/js.ts
  • libs/ledger-live-common/src/families/aptos/js-broadcast.ts
  • libs/ledger-live-common/src/families/aptos/js-prepareTransaction.ts
  • libs/ledger-live-common/src/families/aptos/logic.ts

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@may01 may01 requested review from a team as code owners December 19, 2024 17:20
Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
web-tools βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jan 3, 2025 3:13pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 3:13pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 3:13pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 3, 2025 3:13pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools translations Translation files have been touched cli labels Dec 19, 2024
@may01 may01 changed the base branch from develop to feat/integrate-aptos December 19, 2024 17:20
@may01 may01 force-pushed the feat/LIVE-15126-APTOS-Unit-tests-Bride-Boradcast-PrepareTransactions branch from 45b9f18 to 65fb875 Compare December 19, 2024 18:03
@live-github-bot live-github-bot bot removed desktop Has changes in LLD mobile Has changes in LLM ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools translations Translation files have been touched cli labels Dec 19, 2024
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Dec 19, 2024

Desktop Bundle Checks

Comparing 862f5f7 against ddaf8a4.

⚠️ renderer bundle size significantly increased: 36.7mb -> 37.8mb. Please check if this is expected.

Mobile Bundle Checks

Comparing 862f5f7 against ddaf8a4.

⚠️ main.ios.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 60.3mb -> 61.7mb. Please check if this is expected.

Copy link
Member

@jccguimaraes jccguimaraes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase/merge with the feature branch in order to have green CI, thanks

@may01 may01 merged commit 854b90d into feat/integrate-aptos Jan 3, 2025
48 of 49 checks passed
@may01 may01 deleted the feat/LIVE-15126-APTOS-Unit-tests-Bride-Boradcast-PrepareTransactions branch January 3, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants