Multiversx rebranding bis #8757

Wozacosta · 2024-12-23T15:58:29Z

✅ Checklist

npx changeset was attached.
Covered by automatic tests.
Impact of the changes:
- ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

LIVE-12881

🧐 Checklist for the PR Reviewers

The code aligns with the requirements described in the linked JIRA or GitHub issue.
The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
There are no undocumented trade-offs, technical debt, or maintainability issues.
The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
Any new dependencies have been justified and documented.
Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

vercel · 2024-12-23T15:58:33Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments

Name	Status	Preview	Updated (UTC)
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview	Jan 2, 2025 4:00pm
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jan 2, 2025 4:00pm
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview	Jan 2, 2025 4:00pm
web-tools	⬜️ Ignored (Inspect)	Visit Preview	Jan 2, 2025 4:00pm

ledger-wiz-cspm-secret-detection · 2024-12-23T15:58:57Z

Wiz Scan Summary

Scanner	Findings
Sensitive Data	3
Secrets
IaC Misconfigurations

Total	3

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

live-github-bot · 2024-12-23T16:33:23Z

Mobile Bundle Checks

Comparing 58ff42c against 8d2cf10.

🚀 main.ios.jsbundle bundle size decreased (60.3mb -> 60.2mb). Thanks ❤️
🚀 main.android.jsbundle bundle size decreased (60.3mb -> 60.2mb). Thanks ❤️

Desktop Bundle Checks

Comparing 58ff42c against 8d2cf10.

✅ Previous issues have all been fixed.

github-actions · 2025-01-03T09:57:37Z

[Bot] Testing with 'Nitrogen' ✅ 3 txs ($32.90) ⏲ 2min 1s

✅ 1 specs are successful: MultiversX

What is the bot and how does it work? Everything is documented here!

⚠️ 1 spec hints

Spec MultiversX:
- mutations should define a testDestination(): move some ESDT

Details of the 3 mutations

Spec MultiversX (8)

Spec MultiversX found 8 MultiversX accounts (preload: 248ms). Will use MultiversX 1.0.20 on nanoS 2.1.0
undefined: 0.00089732 EGLD (483ops) (erd18n5sk95fq9dtgdsa9m9q5ddp66ch9cq5lpjflwn5j9z8x2e9h0qqrvk5qp on 44'/508'/0'/0/0) #0 js:2:elrond:erd18n5sk95fq9dtgdsa9m9q5ddp66ch9cq5lpjflwn5j9z8x2e9h0qqrvk5qp:
undefined: 0 EGLD (529ops) (erd172muqtk2ka5ath64284fm0av4tarkg6l040c595uswwz3tgngh9s9dtgp6 on 44'/508'/1'/0/0) #1 js:2:elrond:erd172muqtk2ka5ath64284fm0av4tarkg6l040c595uswwz3tgngh9s9dtgp6:
undefined: 0.00087061 EGLD (513ops) (erd1ql9pxrhe29cjr8qgxx3rtmh9lyax5x9dkvu3mfzrgt4e8hwk536ssl4sea on 44'/508'/2'/0/0) #2 js:2:elrond:erd1ql9pxrhe29cjr8qgxx3rtmh9lyax5x9dkvu3mfzrgt4e8hwk536ssl4sea:
undefined: 0.0175056 EGLD (478ops) (erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn on 44'/508'/3'/0/0) #3 js:2:elrond:erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn:
undefined: 0.0144486 EGLD (453ops) (erd149kzxgtymzzaddanlj02zhyhwves9wspvk8p69u325tjln5en9aqf8x8el on 44'/508'/4'/0/0) #4 js:2:elrond:erd149kzxgtymzzaddanlj02zhyhwves9wspvk8p69u325tjln5en9aqf8x8el:
undefined: 0 EGLD (405ops) (erd143yn6uvrfzjptq5g7wvzntl3fcthsxtxrp9f3dgasluj6q5n0pxq2td67n on 44'/508'/5'/0/0) #5 js:2:elrond:erd143yn6uvrfzjptq5g7wvzntl3fcthsxtxrp9f3dgasluj6q5n0pxq2td67n:
undefined: 0.880258 EGLD (323ops) (erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7 on 44'/508'/6'/0/0) #6 js:2:elrond:erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7:
undefined: 0 EGLD (0ops) (erd1w4jjugkk5rp8hn8erefltjn0xek4x60t4hzsmnkfty7930sxujtqgryqgw on 44'/508'/7'/0/0) #7 js:2:elrond:erd1w4jjugkk5rp8hn8erefltjn0xek4x60t4hzsmnkfty7930sxujtqgryqgw:
necessary accounts resynced in 0.14ms
▬ MultiversX 1.0.20 on nanoS 2.1.0
→ FROM undefined: 0.0175056 EGLD (478ops) (erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn on 44'/508'/3'/0/0) #3 js:2:elrond:erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn: 0.017505662168844487 EGLD spendable. 
  nonce : 271
  TokenAccount MEX: 29.048365756348314637 MEX (147 ops)
  TokenAccount RARE: 1.451682719242338828 RARE (23 ops) (! sum of ops -5.448317280757661172 RARE)
max spendable ~0.0174556
★ using mutation 'move some ESDT'
→ TO undefined: 0.880258 EGLD (323ops) (erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7 on 44'/508'/6'/0/0) #6 js:2:elrond:erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7:
✔️ transaction 
SEND  26.437852990581869878 MEX
TO erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7
STATUS (3.40ms)
  amount: 26.437852990581869878 MEX
  estimated fees: 0.00013172 EGLD
  total spent: 26.437852990581869878 MEX
errors: 
warnings: 
✔️ has been signed! (3.2s) 
✔️ broadcasted! (159ms) optimistic operation: 
  -0.00013172 EGLD   OUT        4a273b974cacff5e8ebd2d359737b6ff3f21f9609f7cd0c84ea9977b0a104e61 2025-01-03T09:56
    -26.437852990581869878 MEX OUT        
✔️ operation confirmed (11.8s): 
  -0.00013 EGLD      OUT        4a273b974cacff5e8ebd2d359737b6ff3f21f9609f7cd0c84ea9977b0a104e61 2025-01-03T09:56
    -26.437852990581869878 MEX OUT        
✔️ undefined: 0.0173756 EGLD (479ops) (erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn on 44'/508'/3'/0/0) #3 js:2:elrond:erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn: 0.017375662168844487 EGLD spendable. 
  nonce : 272
  TokenAccount MEX: 2.610512765766444759 MEX (148 ops)
  TokenAccount RARE: 1.451682719242338828 RARE (23 ops) (! sum of ops -5.448317280757661172 RARE)(in 11.8s)

necessary accounts resynced in 1767ms
▬ MultiversX 1.0.20 on nanoS 2.1.0
→ FROM undefined: 0.0144486 EGLD (453ops) (erd149kzxgtymzzaddanlj02zhyhwves9wspvk8p69u325tjln5en9aqf8x8el on 44'/508'/4'/0/0) #4 js:2:elrond:erd149kzxgtymzzaddanlj02zhyhwves9wspvk8p69u325tjln5en9aqf8x8el: 0.01444866482093683 EGLD spendable. 
  nonce : 242
  TokenAccount MEX: 1.286173569236152016 MEX (135 ops)
  TokenAccount RARE: 0.437689524489295557 RARE (16 ops)
max spendable ~0.0143986
★ using mutation 'send 50%~'
→ TO undefined: 0.0173756 EGLD (479ops) (erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn on 44'/508'/3'/0/0) #3 js:2:elrond:erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn:
✔️ transaction 
SEND  0.007114902984592227 EGLD
TO erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn
STATUS (1.19ms)
  amount: 0.007114902984592227 EGLD
  estimated fees: 0.00005 EGLD
  total spent: 0.007164902984592227 EGLD
errors: 
warnings: 
✔️ has been signed! (2917ms) 
✔️ broadcasted! (129ms) optimistic operation: 
  -0.007164902984592227 EGLD OUT        38ec2796947c533045a71e1a686b501cc7a0bd0fb1bc568295b00dc6d0a8d5a8 2025-01-03T09:56
✔️ operation confirmed (11.7s): 
  -0.007164902984592227 EGLD OUT        38ec2796947c533045a71e1a686b501cc7a0bd0fb1bc568295b00dc6d0a8d5a8 2025-01-03T09:56
✔️ undefined: 0.00728376 EGLD (454ops) (erd149kzxgtymzzaddanlj02zhyhwves9wspvk8p69u325tjln5en9aqf8x8el on 44'/508'/4'/0/0) #4 js:2:elrond:erd149kzxgtymzzaddanlj02zhyhwves9wspvk8p69u325tjln5en9aqf8x8el: 0.007283761836344603 EGLD spendable. 
  nonce : 243
  TokenAccount MEX: 1.286173569236152016 MEX (135 ops)
  TokenAccount RARE: 0.437689524489295557 RARE (16 ops)(in 11.7s)
✔️ destination operation 
  +0.007114902984592227 EGLD IN         38ec2796947c533045a71e1a686b501cc7a0bd0fb1bc568295b00dc6d0a8d5a8 2025-01-03T09:56
(in 11.7s)

necessary accounts resynced in 0.13ms
▬ MultiversX 1.0.20 on nanoS 2.1.0
→ FROM undefined: 0.880258 EGLD (324ops) (erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7 on 44'/508'/6'/0/0) #6 js:2:elrond:erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7: 0.880258509430314517 EGLD spendable. 
  nonce : 60
  TokenAccount MEX: 30.474533778932987602 MEX (90 ops) (! sum of ops 56.91238676951485748 MEX)
  TokenAccount RARE: 14.895870083181556483 RARE (16 ops)
max spendable ~0.880208
★ using mutation 'send max'
→ TO undefined: 0 EGLD (405ops) (erd143yn6uvrfzjptq5g7wvzntl3fcthsxtxrp9f3dgasluj6q5n0pxq2td67n on 44'/508'/5'/0/0) #5 js:2:elrond:erd143yn6uvrfzjptq5g7wvzntl3fcthsxtxrp9f3dgasluj6q5n0pxq2td67n:
✔️ transaction 
SEND MAX
TO erd143yn6uvrfzjptq5g7wvzntl3fcthsxtxrp9f3dgasluj6q5n0pxq2td67n
STATUS (0.84ms)
  amount: 0.880208509430314517 EGLD
  estimated fees: 0.00005 EGLD
  total spent: 0.880258509430314517 EGLD
errors: 
warnings: 
✔️ has been signed! (2901ms) 
✔️ broadcasted! (142ms) optimistic operation: 
  -0.880258509430314517 EGLD OUT        af8ac7bff97dc1b8175043ef433f08e139f5595a0cd38464a3ca2bc292d225e1 2025-01-03T09:57
✔️ operation confirmed (11.8s): 
  -0.880258509430314517 EGLD OUT        af8ac7bff97dc1b8175043ef433f08e139f5595a0cd38464a3ca2bc292d225e1 2025-01-03T09:57
✔️ undefined: 0 EGLD (325ops) (erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7 on 44'/508'/6'/0/0) #6 js:2:elrond:erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7: 0 EGLD spendable. 
  nonce : 61
  TokenAccount MEX: 56.91238676951485748 MEX (90 ops)
  TokenAccount RARE: 14.895870083181556483 RARE (16 ops)(in 11.8s)
✔️ destination operation 
  +0.880208509430314517 EGLD IN         af8ac7bff97dc1b8175043ef433f08e139f5595a0cd38464a3ca2bc292d225e1 2025-01-03T09:57
(in 22.2s)

Details of the 3 uncovered mutations

Spec MultiversX (3)

delegate 1 EGLD: balance is too low (5)
unDelegate 1 EGLD: balance is too low (5)
withdraw all EGLD: balance is too low (5)

Portfolio ($32.90) – Details of the 1 currencies

Spec (accounts)	State	Remaining Runs (est)	funds?
MultiversX (8)	3190 ops (+6), 0.91398 EGLD ($32.90)	💪 999+	`erd18n5sk95fq9dtgdsa9m9q5ddp66ch9cq5lpjflwn5j9z8x2e9h0qqrvk5qp`

undefined: 0.00089732 EGLD (483ops) (erd18n5sk95fq9dtgdsa9m9q5ddp66ch9cq5lpjflwn5j9z8x2e9h0qqrvk5qp on 44'/508'/0'/0/0) #0 js:2:elrond:erd18n5sk95fq9dtgdsa9m9q5ddp66ch9cq5lpjflwn5j9z8x2e9h0qqrvk5qp:
undefined: 0 EGLD (529ops) (erd172muqtk2ka5ath64284fm0av4tarkg6l040c595uswwz3tgngh9s9dtgp6 on 44'/508'/1'/0/0) #1 js:2:elrond:erd172muqtk2ka5ath64284fm0av4tarkg6l040c595uswwz3tgngh9s9dtgp6:
undefined: 0.00087061 EGLD (513ops) (erd1ql9pxrhe29cjr8qgxx3rtmh9lyax5x9dkvu3mfzrgt4e8hwk536ssl4sea on 44'/508'/2'/0/0) #2 js:2:elrond:erd1ql9pxrhe29cjr8qgxx3rtmh9lyax5x9dkvu3mfzrgt4e8hwk536ssl4sea:
undefined: 0.0244905 EGLD (480ops) (erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn on 44'/508'/3'/0/0) #3 js:2:elrond:erd1sjvd5mh946cty4wq0ya0d82509tc8eulxjujrad5ztfwjlhkqz0qy5yzmn:
undefined: 0.00728376 EGLD (454ops) (erd149kzxgtymzzaddanlj02zhyhwves9wspvk8p69u325tjln5en9aqf8x8el on 44'/508'/4'/0/0) #4 js:2:elrond:erd149kzxgtymzzaddanlj02zhyhwves9wspvk8p69u325tjln5en9aqf8x8el:
undefined: 0.880208 EGLD (406ops) (erd143yn6uvrfzjptq5g7wvzntl3fcthsxtxrp9f3dgasluj6q5n0pxq2td67n on 44'/508'/5'/0/0) #5 js:2:elrond:erd143yn6uvrfzjptq5g7wvzntl3fcthsxtxrp9f3dgasluj6q5n0pxq2td67n:
undefined: 0 EGLD (325ops) (erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7 on 44'/508'/6'/0/0) #6 js:2:elrond:erd1nhe920dlsx8u0lg46grd82dc8vqj8wejh8u7xcdjzfr8yy8ncdtsgtgjz7:
undefined: 0 EGLD (0ops) (erd1w4jjugkk5rp8hn8erefltjn0xek4x60t4hzsmnkfty7930sxujtqgryqgw on 44'/508'/7'/0/0) #7 js:2:elrond:erd1w4jjugkk5rp8hn8erefltjn0xek4x60t4hzsmnkfty7930sxujtqgryqgw:

Performance ⏲ 2min 1s

Time spent for each spec: (total across mutations)

Spec (accounts)	preload	scan	re-sync	tx status	sign op	broadcast	test	destination test
TOTAL	248ms	38.5s	1768ms	5ms	9s	430ms	35.3s	33.9s
MultiversX (7)	248ms	38.5s	1768ms	5ms	9s	430ms	35.3s	33.9s

What is the bot and how does it work? Everything is documented here!

Canestin

Got this error when trying to launch on LLD :

github-actions bot assigned Wozacosta Dec 23, 2024

live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs tools Has changes in tools cli labels Dec 23, 2024

Wozacosta force-pushed the multiversx-rebranding-bis branch from 8937181 to bd3a9fc Compare December 23, 2024 16:12

vercel bot deployed to Preview – web-tools December 23, 2024 16:47 View deployment

vercel bot deployed to Preview – web-tools December 23, 2024 16:53 View deployment

vercel bot deployed to Preview – web-tools December 23, 2024 17:06 View deployment

vercel bot deployed to Preview – web-tools December 23, 2024 17:19 View deployment

vercel bot deployed to Preview – web-tools December 23, 2024 17:40 View deployment

vercel bot deployed to Preview – web-tools December 24, 2024 10:42 View deployment

vercel bot deployed to Preview – web-tools December 24, 2024 10:54 View deployment

vercel bot deployed to Preview – web-tools December 24, 2024 11:04 View deployment

vercel bot deployed to Preview – web-tools December 24, 2024 11:14 View deployment

vercel bot deployed to Preview – web-tools December 24, 2024 16:17 View deployment

vercel bot deployed to Preview – web-tools December 24, 2024 16:47 View deployment

Wozacosta mentioned this pull request Dec 24, 2024

Multiversx Rebranding #8630

Closed

3 tasks

popenta added 7 commits January 2, 2025 10:29

initial renaming

8c81b4e

second part of renaming

794eb82

more renaming

bc26b21

rename lld directory

38eb4ac

fix import statements

081b07d

rename env api endpoints

99a8cbf

rename coin module

dfa130d

popenta and others added 18 commits January 2, 2025 10:29

revert to old currency id

20dbe06

generate changeset

a1372b3

fix changeset

62a5ed1

pnpmlock update

0d11464

dataset revert

fc0cd67

revert id

3dca780

update snap

8ee6a8e

cleanup + fix tests

a963d4c

unimported + sortbymarketcap

70d2e75

id in snapshots of wallet-api specs

c87291f

elrond missing from sortbymarketcap snap

859ece0

bcname elrond in cryptoassetsimporter

b13589e

update unimported

98f1da8

update snap currencies

9ce3046

family elrond

8797f4e

doc update

2f85b97

temp removal of snapshot elrond

914123b

rename elrond mvx wapi constants

6c1e2dc

Wozacosta force-pushed the multiversx-rebranding-bis branch from 89422aa to 6c1e2dc Compare January 2, 2025 09:29

vercel bot had a problem deploying to Preview – web-tools January 2, 2025 09:36 Failure

newline end of wallet-api spec file

8b1a0e2

Wozacosta marked this pull request as ready for review January 2, 2025 15:40

Wozacosta requested review from a team as code owners January 2, 2025 15:40

Fix error not rebranded

9086686

live-github-bot bot added the translations Translation files have been touched label Jan 2, 2025

Canestin reviewed Jan 7, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Multiversx rebranding bis #8757

Multiversx rebranding bis #8757

Wozacosta commented Dec 23, 2024 •

edited by jira bot

Loading

vercel bot commented Dec 23, 2024 •

edited

Loading

ledger-wiz-cspm-secret-detection bot commented Dec 23, 2024 •

edited

Loading

live-github-bot bot commented Dec 23, 2024 •

edited

Loading

github-actions bot commented Jan 3, 2025

Spec MultiversX (8)

Spec MultiversX (3)

Canestin left a comment

Multiversx rebranding bis #8757

Are you sure you want to change the base?

Multiversx rebranding bis #8757

Conversation

Wozacosta commented Dec 23, 2024 • edited by jira bot Loading

✅ Checklist

📝 Description

❓ Context

🧐 Checklist for the PR Reviewers

vercel bot commented Dec 23, 2024 • edited Loading

ledger-wiz-cspm-secret-detection bot commented Dec 23, 2024 • edited Loading

Wiz Scan Summary

live-github-bot bot commented Dec 23, 2024 • edited Loading

Mobile Bundle Checks

Desktop Bundle Checks

github-actions bot commented Jan 3, 2025

[Bot] Testing with 'Nitrogen' ✅ 3 txs ($32.90) ⏲ 2min 1s

Spec MultiversX (8)

Spec MultiversX (3)

Canestin left a comment

Choose a reason for hiding this comment

Wozacosta commented Dec 23, 2024 •

edited by jira bot

Loading

vercel bot commented Dec 23, 2024 •

edited

Loading

ledger-wiz-cspm-secret-detection bot commented Dec 23, 2024 •

edited

Loading

live-github-bot bot commented Dec 23, 2024 •

edited

Loading