-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 (rn-ble) [ACRE]: Device disconnected error when trying to sign in on Acre #8774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
live-github-bot
bot
added
mobile
Has changes in LLM
ledgerjs
Has changes in the ledgerjs open source libs
labels
Dec 30, 2024
jdabbech-ledger
force-pushed
the
fix/live-15119-acre-ble-connectivity
branch
from
December 31, 2024 13:23
10f3990
to
b7205ba
Compare
jdabbech-ledger
force-pushed
the
fix/live-15119-acre-ble-connectivity
branch
2 times, most recently
from
January 2, 2025 09:19
acea6e8
to
b4f5a02
Compare
jdabbech-ledger
force-pushed
the
fix/live-15119-acre-ble-connectivity
branch
from
January 6, 2025 09:18
b4f5a02
to
9f9300b
Compare
jdabbech-ledger
force-pushed
the
fix/live-15119-acre-ble-connectivity
branch
from
January 6, 2025 09:18
9f9300b
to
6378982
Compare
jdabbech-ledger
force-pushed
the
fix/live-15119-acre-ble-connectivity
branch
from
January 6, 2025 17:02
6378982
to
00f101f
Compare
valpinkman
previously approved these changes
Jan 7, 2025
LucasWerey
reviewed
Jan 7, 2025
.changeset/clever-tables-draw.md
Outdated
@@ -0,0 +1,6 @@ | |||
--- | |||
"@ledgerhq/react-native-hw-transport-ble": patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use minor instead
.changeset/young-bottles-flow.md
Outdated
@@ -0,0 +1,5 @@ | |||
--- | |||
"live-mobile": patch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
jdabbech-ledger
force-pushed
the
fix/live-15119-acre-ble-connectivity
branch
from
January 7, 2025 18:06
00f101f
to
9b6bf19
Compare
jdabbech-ledger
force-pushed
the
fix/live-15119-acre-ble-connectivity
branch
from
January 8, 2025 09:59
9b6bf19
to
bfe0037
Compare
jdabbech-ledger
force-pushed
the
fix/live-15119-acre-ble-connectivity
branch
from
January 8, 2025 10:00
bfe0037
to
8cf98f7
Compare
LucasWerey
approved these changes
Jan 8, 2025
valpinkman
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ Checklist
npx changeset
was attached.📝 Description
Extract Ble plx instance to a specific class in @ledgerhq/react-native-hw-transport-ble
Added missing promise awaiting
Update react-native-ble-plx to 3.2.1
❓ Context
🧐 Checklist for the PR Reviewers