Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 (rn-ble) [ACRE]: Device disconnected error when trying to sign in on Acre #8774

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jdabbech-ledger
Copy link
Contributor

@jdabbech-ledger jdabbech-ledger commented Dec 30, 2024

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • Extract Ble plx instance to a specific class in @ledgerhq/react-native-hw-transport-ble

  • Added missing promise awaiting

  • Update react-native-ble-plx to 3.2.1

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jdabbech-ledger jdabbech-ledger requested a review from a team as a code owner December 30, 2024 12:15
Copy link

vercel bot commented Dec 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 10:10am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 10:10am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 10:10am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 10:10am

valpinkman
valpinkman previously approved these changes Jan 7, 2025
@@ -0,0 +1,6 @@
---
"@ledgerhq/react-native-hw-transport-ble": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use minor instead

@@ -0,0 +1,5 @@
---
"live-mobile": patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@jdabbech-ledger jdabbech-ledger merged commit d56a754 into develop Jan 8, 2025
52 of 53 checks passed
@jdabbech-ledger jdabbech-ledger deleted the fix/live-15119-acre-ble-connectivity branch January 8, 2025 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants