Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QAA-354] playwright e2e speculos tests with Prod env #8788

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

VicAlbr
Copy link
Contributor

@VicAlbr VicAlbr commented Jan 2, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 8:30am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 8:30am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 8:30am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 8:30am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jan 2, 2025
@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Jan 2, 2025

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data 2 Info
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations
Total 2 Info

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@VicAlbr VicAlbr requested a review from mohamedzitouni January 2, 2025 15:02
@VicAlbr VicAlbr marked this pull request as ready for review January 6, 2025 11:26
@VicAlbr VicAlbr requested review from a team as code owners January 6, 2025 11:26
@VicAlbr VicAlbr merged commit d9d8f8b into develop Jan 8, 2025
40 of 41 checks passed
@VicAlbr VicAlbr deleted the support/qaa-354 branch January 8, 2025 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants