Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA-377][Speculos][Detox] Adapt LLM send test #8796

Merged
merged 5 commits into from
Jan 8, 2025
Merged

[QAA-377][Speculos][Detox] Adapt LLM send test #8796

merged 5 commits into from
Jan 8, 2025
+396 −37

Conversation

abdurrahman-ledger
Copy link
Contributor

@abdurrahman-ledger abdurrahman-ledger commented Jan 3, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached. (no need)
  • Covered by automatic tests.
  • Impact of the changes:
    • LLM Speculos test
    • LLMSpeculos notif

📝 Description

Added first LLM Speculos send tests

Also :

  • Fixed retryal of failed tests by patching Detox
  • Fixed Slack notification color by taking into account all shards result

❓ Context

Screenshot 2025-01-06 at 09 49 56

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 8, 2025 9:23am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 9:23am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 9:23am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 9:23am

@live-github-bot live-github-bot bot added mobile Has changes in LLM common Has changes in live-common labels Jan 3, 2025
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_377_detox_speculos_send branch from 1a168e3 to e6f5697 Compare January 3, 2025 11:32
@live-github-bot live-github-bot bot added the automation CI/CD stuff label Jan 3, 2025
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_377_detox_speculos_send branch 3 times, most recently from 7360772 to 3940f29 Compare January 3, 2025 17:40
@abdurrahman-ledger abdurrahman-ledger force-pushed the support/qaa_377_detox_speculos_send branch from 3940f29 to 3af2ca8 Compare January 3, 2025 19:08
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review January 3, 2025 20:57
@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners January 3, 2025 20:57
hedi-edelbloute
hedi-edelbloute previously approved these changes Jan 8, 2025
View reviewed changes
libs/ledger-live-common/src/e2e/speculos.ts Outdated Show resolved Hide resolved
themooneer
themooneer approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@themooneer themooneer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abdurrahman-ledger abdurrahman-ledger merged commit e785a43 into develop Jan 8, 2025
64 of 65 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/qaa_377_detox_speculos_send branch January 8, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themooneer themooneer themooneer approved these changes

@hedi-edelbloute hedi-edelbloute Awaiting requested review from hedi-edelbloute

@ypolishchuk-ledger ypolishchuk-ledger Awaiting requested review from ypolishchuk-ledger

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
automation CI/CD stuff common Has changes in live-common mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abdurrahman-ledger @themooneer @hedi-edelbloute @ypolishchuk-ledger