Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: aptos addresses #8841

Merged
merged 2 commits into from
Jan 8, 2025
Merged

fix: aptos addresses #8841

merged 2 commits into from
Jan 8, 2025

Conversation

semeano
Copy link
Contributor

@semeano semeano commented Jan 8, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

The Aptos addresses were switched, and the E2E tests are failing. This PR fixes this issue.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@semeano semeano requested a review from a team as a code owner January 8, 2025 10:08
Copy link

vercel bot commented Jan 8, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 1:20pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 1:20pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 1:20pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 8, 2025 1:20pm

VicAlbr
VicAlbr previously approved these changes Jan 8, 2025
@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jan 8, 2025
@semeano semeano force-pushed the fix/aptos-e2e-addresses branch from b1583b3 to 1d5d1d6 Compare January 8, 2025 13:18
@live-github-bot live-github-bot bot removed the mobile Has changes in LLM label Jan 8, 2025
@semeano semeano requested a review from VicAlbr January 8, 2025 13:21
@semeano semeano merged commit 114d419 into develop Jan 8, 2025
55 checks passed
@semeano semeano deleted the fix/aptos-e2e-addresses branch January 8, 2025 15:53
may01 pushed a commit that referenced this pull request Jan 9, 2025
@jprudent jprudent mentioned this pull request Jan 10, 2025
joaoccmartins pushed a commit that referenced this pull request Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
common Has changes in live-common
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants