Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: QR code scanning was failing to retrieve recipient's address in send flow #8850

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mcayuelas-ledger
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger commented Jan 9, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

QR code scanning was failing to retrieve the recipient's address in the send flow due to the update to the latest version of React Native.

Additionally, expo-camera/legacy was no longer functioning properly.

  • reuse of what we have done in LedgerSync
Screen_Recording_20250109_112205_LL.DEV.mp4

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@mcayuelas-ledger mcayuelas-ledger requested a review from a team as a code owner January 9, 2025 10:30
Copy link

vercel bot commented Jan 9, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 3:42pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 3:42pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 3:42pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 9, 2025 3:42pm

@live-github-bot live-github-bot bot added mobile Has changes in LLM translations Translation files have been touched labels Jan 9, 2025
@mcayuelas-ledger mcayuelas-ledger force-pushed the bugfix/scan-qr-receive-flow branch 2 times, most recently from 531fb50 to cc15ba0 Compare January 9, 2025 14:45
LucasWerey
LucasWerey previously approved these changes Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM translations Translation files have been touched
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants