Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

πŸ’„ (llm) animation enhancement tab switch #8976

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

LucasWerey
Copy link
Contributor

@LucasWerey LucasWerey commented Jan 22, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • tab section with assets and accounts lists

πŸ“ Description

Enhance tab switch animation on portfolioAssets.
The animation is quite complex to set up since we use virtualised lists. I tried to explain what I did with comments in the code so it's easier to understand

Simulator.Screen.Recording.-.iPhone.15.-.2025-01-22.at.14.28.17.mp4
Screen.Recording.2025-01-22.at.2.54.50.PM.mov

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner January 22, 2025 09:29
Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 1:39pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 1:39pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 1:39pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Jan 22, 2025 1:39pm

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant