feat: sell and fund flow [LIVE-784] #91
Conversation
handle exchange action add new tracking events implement startExchange [WIP] fix completeExchange error fix crash on completeExchange fix crash on completeExchange use same device for start and complete exchange action cleanup show device animation on exchange flow fix fund device action modal fix fund action message remove unnecessary changes add comments for exchangeType
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: bf12e0f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
mobile
Screenshots: ❌
It seems this PR contains screenshots that are different from the base branch.
windows
|
using slice fixes the issue (needs more digging to understand the root cause)
Codecov Report
@@ Coverage Diff @@
## develop #91 +/- ##
============================================
+ Coverage 0 56.95% +56.95%
============================================
Files 0 516 +516
Lines 0 21468 +21468
Branches 0 5748 +5748
============================================
+ Hits 0 12228 +12228
- Misses 0 9194 +9194
- Partials 0 46 +46
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Successful Fund on Android (physical) with Nano X Screen.Recording.2022-06-10.at.13.28.28.mov |
|
Unsuccessful fund on iOS when it freezes on the 'complete' phase' Screen.Recording.2022-06-10.at.13.43.18.movSuccessful iOS fund on Nano X: Screen.Recording.2022-06-10.at.13.46.52.mov |
|
I was also able to do some funds on both ETH and BTC on LLM on Baanx, however the device interactions were very flaky and on Android the BTC 'confirm exchange' step would not show up on the Nano. See photos of where it stopped:
My recommendation at this stage is we could merge this as the basic flows have been proved to be working (successful funds/sells on the exchange test app, and ETH and BTC funds on Baanx), however the sell is very flaky and requires a lot more testing on a stable environment. If we merge this (as long as it is not usable by users) then we will be able to test this on actual iOS/Android devices with proper builds and without relying on dev builds, http proxies and debug nano apps, which make it tricky to tell if any issues are with the app or with our test setup. Once this is merged we should test the following on physical iPhones and Android phones:
|
❓ Context
live-mobile]Old pr: LIVE-784 Sell and Fund flow ledger-live-mobile#2232
It's the same as LedgerHQ/ledger-live-desktop#4361 but for mobile.
✅ Checklist
📸 Demo
fund-flow.mov
🚀 Expectations to reach
Please make sure you follow these Important Steps.
Pull Requests must pass the CI and be internally validated in order to be merged.
Parts of the app affected / Test plan
PS: You will need a test version of the exchange app to test the fund flow, cf. the platform-app-test-exchange README for details.
.env
manifest.json
{ "id": "test-app", "name": "Test app", "url": "http://localhost:3000", "homepageUrl": "https://developers.ledger.com/", "icon": "", "platform": "all", "apiVersion": "0.0.1", "manifestVersion": "1", "branch": "debug", "categories": ["tools"], "currencies": "*", "content": { "shortDescription": { "en": "Test Live App. Use at your own risk." }, "description": { "en": "Test Live App. Use at your own risk." } }, "permissions": [ { "method": "*" } ], "domains": [ "https://*", "http://*" ] }