API_LEVEL_19 and software swipe support #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qt window: - Do not move the Qt window when "swiping" the window - Enable Qt window border screen.py: - Send a dummy "press" event when releasing the mouse, in order to trigger swipe detection.
abonnaudet-ledger
force-pushed
the
abo_api_level_19
branch
from
8059520
to
c6c95b2
Compare
xchapron-ledger
previously approved these changes
Apr 29, 2024
|
Would be nice to add swipe support in here: https://github.com/LedgerHQ/speculos/blob/master/speculos/api/finger.py |
lpascal-ledger
force-pushed
the
abo_api_level_19
branch
3 times, most recently
from
a3e7df4
to
731ce09
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #481 +/- ##
==========================================
- Coverage 52.12% 52.09% -0.04%
==========================================
Files 120 120
Lines 12026 12039 +13
Branches 964 964
==========================================
+ Hits 6269 6272 +3
- Misses 5422 5432 +10
Partials 335 335 ☔ View full report in Codecov by Sentry. |
lpascal-ledger
force-pushed
the
abo_api_level_19
branch
from
731ce09
to
cd9b649
Compare
xchapron-ledger
approved these changes
May 6, 2024
|
@xchapron-ledger swipe was tested and working on Boilerplate. As for the Boilerplate tests suite, they fails on two types of errors:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.