Fix wrong display of some image files when BPP is not properly set in area #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nroggeman-ledger
force-pushed
the
fix-bad-nbgl-image-file-display
branch
from
700d876
to
89610c8
Compare
cedelavergne-ledger
approved these changes
Jul 12, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 44.99% 44.99% -0.01%
==========================================
Files 120 120
Lines 12045 12046 +1
Branches 964 964
==========================================
Hits 5420 5420
- Misses 6290 6291 +1
Partials 335 335 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to fix potential inconsistency between the number of BPP set in the area and the number of BPP set in image "file" header. The Header is supposed to be the good one so the one in the area must be overriden.