Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Add pyqt5 dependency #541

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aussedatlo
Copy link

@aussedatlo aussedatlo commented Dec 19, 2024

This PR aims to add pyqt5 support to be able to run speculos with qt.

WARNING: As the qt library is not very light, the image size is now 1.24GB instead of 800MB.

@ledger-wiz-cspm-secret-detection

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data
Secret Finding Secrets
IaC Misconfiguration IaC Misconfigurations 1 High 2 Medium
Total 1 High 2 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Dec 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.83%. Comparing base (68d20b7) to head (fea420a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #541   +/-   ##
=======================================
  Coverage   43.83%   43.83%           
=======================================
  Files         125      125           
  Lines       12456    12456           
  Branches      994      994           
=======================================
  Hits         5460     5460           
  Misses       6661     6661           
  Partials      335      335           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aussedatlo aussedatlo marked this pull request as draft January 6, 2025 08:19
@aussedatlo aussedatlo force-pushed the mac-qt-support branch 2 times, most recently from 8bebdb9 to f188437 Compare January 13, 2025 15:04
@aussedatlo aussedatlo marked this pull request as ready for review January 13, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants