Skip to content

Commit

Permalink
ci: Remove cspell since it's too aggressive
Browse files Browse the repository at this point in the history
  • Loading branch information
Leleat committed Sep 2, 2023
1 parent 7529397 commit 293b03b
Showing 1 changed file with 1 addition and 23 deletions.
24 changes: 1 addition & 23 deletions .github/workflows/run-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ jobs:
grep -E "\.sh$" |
xargs -r shellcheck
# Unsure, if I really want to do cspell (for .md and .pot files)... The .pot
# file will never be touched by contributors directly. So getting a false flag
# there won't be an issue. That leaves .md files to be spell checked by
# potentional contributors. It kinda makes sense. Problem could be reliability.
spellcheck:
name: Run spell check
runs-on: ubuntu-latest
Expand All @@ -46,32 +42,14 @@ jobs:
- uses: actions/setup-node@v3
with:
node-version: "*"
- run: pip install codespell && npm install -g cspell
- run: pip install codespell
# The case sensitivity of codespeller for ignore-words seems to be buggy. See
# issue tracker. According to the help page it should be case sensitive but
# only 'allws' makes codespeller ignore 'allWs' in code files.
- name: Run codespell
run: >
git diff --name-only --diff-filter=ACMTUXB origin/${{ github.base_ref }} HEAD |
xargs -r codespell -q 3 --skip="*.po*,*.git/*" --ignore-words .github/ignore-words.txt
- name: Configure custom dictionary for cspell based on the ignore list
run: >
echo '{
"version": "0.2",
"dictionaryDefinitions": [{
"name": "dict",
"path": ".github/ignore-words.txt",
"addWords": true
}],
"dictionaries": ["dict"],
}' >> cspell.json
- name: Run cspell (*.md and *.pot)
if: success() || failure()
run: >
git diff --name-only --diff-filter=ACMTUXB origin/${{ github.base_ref }} HEAD |
grep -E "\.(md|pot)$" |
npx cspell lint --color --exclude "CHANGELOG.md" --file-list stdin \
--no-must-find-files --show-context --show-suggestions --unique
build:
name: Run build
Expand Down

0 comments on commit 293b03b

Please sign in to comment.