Small changes #334
Merged
Small changes #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 7, 2024 16:26
Ideally, if a tiled window is dragged around, we'd restore the window size and place the window under cursor when the grab starts. In the past that didn't work consistently for all windows, so I've added the option for the window to restore its size after the grab is released as a workaround. I don't think this is needed anymore, at least from the manual testing I've done... Let's remove this workaround (and see if other people still encounter it).
Putting the keys as static props on classes was meant for convenience. But it wasn't really more convenient... I always needed to look up the keys/props anyway and it was a rather uncommon pattern. So inline the keys now.
so that we don't need to track the signals ourselves with a variable.
`global.display.is_grabbed` replaced `global.display.get_grab_op` since GNOME 44. Since the current extension version only supports GNOME 45+ drop the compatibility code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some small changes/refactoring I had laying around. See commits.