Misc: Ignore error that file exists when creating it #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those files existing is expected at all times after the initial creation.
As a result, journal continued being spammed with errors like:
Gio.IOErrorEnum: Error creating directory ~/.config/tiling-assistant: File exists
Gio.IOErrorEnum: Error opening file “~/.config/tiling-assistant/tiledSessionRestore.json”: File exists
The logging was only added in 50a1757 to appease ESLint,
so let’s add more specific `catch` body instead.
jtojnar
force-pushed
the
silence-expected-exists
branch
from
c5486d2 to
86acc24
Compare
|
Thanks! PS. The CI fails because of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those files existing is expected at all times after the initial creation.
As a result, journal continued being spammed with errors like:
The logging was only added in 50a1757 to appease ESLint,
so let’s add more specific
catchbody instead.