Improve focus hint's compatibility with transparent windows #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 19, 2024 13:37
The outline versions (animated + static) of the focus hint used a widget that is put behind the window with a solid background color. The reasoning behind this is to account for different border radii of windows because if the outline actually uses a border there may be a gap between the focus hint and the window corners. However, this didn't work well with transparent windows. This commit adds an option to change the style of the outline to allow for a border around the window instead of a solid rect. This is also how the previous focus hint (aka active window hint) worked. This means there is a gap between the window corners and the focus hint but that is better than the focus hint being seen through transparent windows. Fixes #375
Previously, the focus hint outline border radius was not exposed in the preferences window becauses I wanted to cut down on the number of settings. However, since the previous commit added already added another setting to make the focus hint a border only, I might as well expose this one too.
Leleat
force-pushed
the
focus-hint-transparent-windows
branch
from
6cb0bfa to
225e053
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commits