✨ Allow for an "All Time" view in statistics page #712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo.554.mp4 |
gBL17
force-pushed
the
main
branch
2 times, most recently
from
e067765
to
5504349
Compare
- Refactor 'calculateGramsDistributionPerDaySinceFirstUse' function for better readability and accuracy - Add unit test for 'createLineDataSet' function to ensure correctness Refactored 'AllTimeGraph' and related components to use the newly modularized logic. # Conflicts: # app/src/main/res/values-pt/strings.xml
- Now the funSpec test are made in getFormattedValue cheking if it return correctly
- Refactored `DaysSinceFirstUseFormatter` to be a class that receives a list of uses and a date format string. - Ensure the formatter returns the correct date format as specified in the settings repository
- Refactor 'calculateGramsDistributionPerDaySinceFirstUse' function for better readability and accuracy - Add unit test for 'createLineDataSet' function to ensure correctness Refactored 'AllTimeGraph' and related components to use the newly modularized logic. # Conflicts: # app/src/main/res/values-pt/strings.xml
This reverts commit 5504349.
gBL17
force-pushed
the
main
branch
2 times, most recently
from
e205b0f
to
f28cae3
Compare
LeoColman
reviewed
Sep 28, 2024
app/src/main/kotlin/br/com/colman/petals/statistics/graph/AllTimeGraph.kt
Outdated
Show resolved
Hide resolved
LeoColman
reviewed
Sep 28, 2024
app/src/main/kotlin/br/com/colman/petals/statistics/graph/AllTimeGraph.kt
Outdated
Show resolved
Hide resolved
LeoColman
reviewed
Sep 28, 2024
app/src/main/kotlin/br/com/colman/petals/statistics/graph/component/LineChart.kt
Outdated
Show resolved
Hide resolved
LeoColman
reviewed
Sep 28, 2024
app/src/main/kotlin/br/com/colman/petals/statistics/graph/component/LineChart.kt
Outdated
Show resolved
Hide resolved
LeoColman
reviewed
Sep 28, 2024
...rc/main/kotlin/br/com/colman/petals/statistics/graph/data/DistributionPerDaySinceFirstUse.kt
Outdated
Show resolved
Hide resolved
LeoColman
reviewed
Sep 28, 2024
...rc/main/kotlin/br/com/colman/petals/statistics/graph/data/DistributionPerDaySinceFirstUse.kt
Outdated
Show resolved
Hide resolved
LeoColman
reviewed
Sep 28, 2024
...rc/main/kotlin/br/com/colman/petals/statistics/graph/formatter/DaysSinceFirstUseFormatter.kt
Outdated
Show resolved
Hide resolved
LeoColman
reviewed
Sep 28, 2024
...rc/main/kotlin/br/com/colman/petals/statistics/graph/data/DistributionPerDaySinceFirstUse.kt
Outdated
Show resolved
Hide resolved
…/DistributionPerDaySinceFirstUse.kt
Updated imports for string resources to improve readability and consistency across the code. Changed value text color from White to Blue for better contrast, and fixed variable naming in date calculations for clarity. Signed-off-by: Leonardo Colman Lopes <[email protected]>
LeoColman
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.