libvncclient: add hooks for custom socket I/O #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Am currently on vacation, can review end of July - how does this relate to / replace #234? |
|
It's related partially only since it proposes changes to the RFB protocol for negotiating TLS. This PR is much more generic and not even TLS related, TLS is just a use case. |
tobydox
force-pushed
the
custom-socket-io
branch
from
032bd7f
to
a30177f
Compare
tobydox
force-pushed
the
custom-socket-io
branch
from
b36c293
to
dcd031d
Compare
|
IIRC this is about generic tunneling, an example of how to make use of this would be super helpful. |
tobydox
force-pushed
the
custom-socket-io
branch
from
dcd031d
to
c47e8b1
Compare
This reverts commit 7dd2750.
This allows using libvncclient on any kind of custom transport, e.g. for TLS tunneling via a special TLS socket implementation.
tobydox
force-pushed
the
custom-socket-io
branch
from
c0796c6
to
72c2e71
Compare
|
I need a connect hook to negotiate with a proxy server before handing the connection to libvncclient. I rolled my own before seeing this one. The ConnectToRFBServer hook proposed here would meet my need. |
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows using libvncclient on any kind of custom transport, e.g. for TLS tunneling via a special TLS socket implementation. May be the function pointer / hook names can be improved to better reflect the actual purpose.